Fix setrefs.c comment properly.

tglsfdc · tglsfdc · commit 87efbc2be12b · 2015-09-10T10:23:56.000-04:00
The "typo" alleged in commit 1e460d4 was actually a comment that was correct when written, but I missed updating it in commit b5282aa. Use a slightly less specific (and hopefully more future-proof) description of what is collected. Back-patch to 9.2 where that commit appeared, and revert the comment to its then-entirely-correct state before that.
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
@@ -1243,7 +1243,7 @@ copyVar(Var *var)
  * This is code that is common to all variants of expression-fixing.
  * We must look up operator opcode info for OpExpr and related nodes,
  * add OIDs from regclass Const nodes into root->glob->relationOids, and
- * add catalog OIDs for user-defined functions into root->glob->invalItems.
+ * add PlanInvalItems for user-defined functions into root->glob->invalItems.
  * We also fill in column index lists for GROUPING() expressions.
  *
  * We assume it's okay to update opcode info in-place.  So this could possibly

Original file line number	Diff line number	Diff line change
`@@ -1243,7 +1243,7 @@ copyVar(Var *var)`
`1243`	`1243`	`* This is code that is common to all variants of expression-fixing.`
`1244`	`1244`	`* We must look up operator opcode info for OpExpr and related nodes,`
`1245`	`1245`	`* add OIDs from regclass Const nodes into root->glob->relationOids, and`
`1246`		`- * add catalog OIDs for user-defined functions into root->glob->invalItems.`
	`1246`	`+ * add PlanInvalItems for user-defined functions into root->glob->invalItems.`
`1247`	`1247`	`* We also fill in column index lists for GROUPING() expressions.`
`1248`	`1248`	`*`
`1249`	`1249`	`* We assume it's okay to update opcode info in-place. So this could possibly`