Improve comments referring snapshot's subxip array.

Amit Kapila · Amit Kapila · commit 8b5262fa0efd · 2022-11-15T09:37:19.000+05:30
It was referred to as subxact array in a few places and subxip array in others. By changing it to subxip array, we make it consistent with similar references to xip array. Author: Japin Li Reviewd by: Julien Rouhaud, Richard Guo Discussion: https://postgr.es/m/MEYP282MB1669DCE7AC193A947CED2A95B6009@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
@@ -2409,7 +2409,7 @@ GetSnapshotData(Snapshot snapshot)
 		 * We could try to store xids into xip[] first and then into subxip[]
 		 * if there are too many xids. That only works if the snapshot doesn't
 		 * overflow because we do not search subxip[] in that case. A simpler
-		 * way is to just store all xids in the subxact array because this is
+		 * way is to just store all xids in the subxip array because this is
 		 * by far the bigger array. We just leave the xip array empty.
 		 *
 		 * Either way we need to change the way XidInMVCCSnapshot() works
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
@@ -2345,7 +2345,7 @@ XidInMVCCSnapshot(TransactionId xid, Snapshot snapshot)
 	else
 	{
 		/*
-		 * In recovery we store all xids in the subxact array because it is by
+		 * In recovery we store all xids in the subxip array because it is by
 		 * far the bigger array, and we mostly don't know which xids are
 		 * top-level and which are subxacts. The xip array is empty.
 		 *

Original file line number	Diff line number	Diff line change
`@@ -2409,7 +2409,7 @@ GetSnapshotData(Snapshot snapshot)`
`2409`	`2409`	`* We could try to store xids into xip[] first and then into subxip[]`
`2410`	`2410`	`* if there are too many xids. That only works if the snapshot doesn't`
`2411`	`2411`	`* overflow because we do not search subxip[] in that case. A simpler`
`2412`		`- * way is to just store all xids in the subxact array because this is`
	`2412`	`+ * way is to just store all xids in the subxip array because this is`
`2413`	`2413`	`* by far the bigger array. We just leave the xip array empty.`
`2414`	`2414`	`*`
`2415`	`2415`	`* Either way we need to change the way XidInMVCCSnapshot() works`
Original file line number	Diff line number	Diff line change
`@@ -2345,7 +2345,7 @@ XidInMVCCSnapshot(TransactionId xid, Snapshot snapshot)`
`2345`	`2345`	`else`
`2346`	`2346`	`{`
`2347`	`2347`	`/*`
`2348`		`- * In recovery we store all xids in the subxact array because it is by`
	`2348`	`+ * In recovery we store all xids in the subxip array because it is by`
`2349`	`2349`	`* far the bigger array, and we mostly don't know which xids are`
`2350`	`2350`	`* top-level and which are subxacts. The xip array is empty.`
`2351`	`2351`	`*`