Fix reported runtime for single tests in pg_regress

danielgustafsson · danielgustafsson · commit 8cb94344c3c7 · 2023-05-16T10:49:48.000+02:00
Commit 558fff0 got the order of the parameters to test_status_failed mixed up which resulted in the runtime being reported as 0 ms. Fix by changing the order to the correct one. No backpatching is needed since this has not been shipped in a release yet. Discussion: https://postgr.es/m/0134C9EC-5F6B-4EAC-B2D5-BB4249BEBD4D@yesql.se
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
@@ -1891,14 +1891,14 @@ run_single_test(const char *test, test_start_function startfunc,
 
 	if (exit_status != 0)
 	{
-		test_status_failed(test, false, INSTR_TIME_GET_MILLISEC(stoptime));
+		test_status_failed(test, INSTR_TIME_GET_MILLISEC(stoptime), false);
 		log_child_failure(exit_status);
 	}
 	else
 	{
 		if (differ)
 		{
-			test_status_failed(test, false, INSTR_TIME_GET_MILLISEC(stoptime));
+			test_status_failed(test, INSTR_TIME_GET_MILLISEC(stoptime), false);
 		}
 		else
 		{

Original file line number	Diff line number	Diff line change
`@@ -1891,14 +1891,14 @@ run_single_test(const char *test, test_start_function startfunc,`
`1891`	`1891`
`1892`	`1892`	`if (exit_status != 0)`
`1893`	`1893`	`{`
`1894`		`- test_status_failed(test, false, INSTR_TIME_GET_MILLISEC(stoptime));`
	`1894`	`+ test_status_failed(test, INSTR_TIME_GET_MILLISEC(stoptime), false);`
`1895`	`1895`	`log_child_failure(exit_status);`
`1896`	`1896`	`}`
`1897`	`1897`	`else`
`1898`	`1898`	`{`
`1899`	`1899`	`if (differ)`
`1900`	`1900`	`{`
`1901`		`- test_status_failed(test, false, INSTR_TIME_GET_MILLISEC(stoptime));`
	`1901`	`+ test_status_failed(test, INSTR_TIME_GET_MILLISEC(stoptime), false);`
`1902`	`1902`	`}`
`1903`	`1903`	`else`
`1904`	`1904`	`{`