Remove unused variable in checksum_file()

tvondra · tvondra · commit 8e392595e561 · 2024-04-05T18:13:15.000+02:00
The 'offset' variable was set but otherwise unused.

Per buildfarm animals with clang, e.g. sifaka and longlin.
diff --git a/src/bin/pg_combinebackup/copy_file.c b/src/bin/pg_combinebackup/copy_file.c
@@ -126,7 +126,6 @@ checksum_file(const char *src, pg_checksum_context *checksum_ctx)
 	uint8	   *buffer;
 	const int	buffer_size = 50 * BLCKSZ;
 	ssize_t		rb;
-	unsigned	offset = 0;
 
 	/* bail out if no checksum needed */
 	if (checksum_ctx->type == CHECKSUM_TYPE_NONE)
@@ -141,8 +140,6 @@ checksum_file(const char *src, pg_checksum_context *checksum_ctx)
 	{
 		if (pg_checksum_update(checksum_ctx, buffer, rb) < 0)
 			pg_fatal("could not update checksum of file \"%s\"", src);
-
-		offset += rb;
 	}
 
 	if (rb < 0)

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,6 @@ checksum_file(const char src, pg_checksum_context checksum_ctx)`
`126`	`126`	`uint8 *buffer;`
`127`	`127`	`const int buffer_size = 50 * BLCKSZ;`
`128`	`128`	`ssize_t rb;`
`129`		`- unsigned offset = 0;`
`130`	`129`
`131`	`130`	`/* bail out if no checksum needed */`
`132`	`131`	`if (checksum_ctx->type == CHECKSUM_TYPE_NONE)`
`@@ -141,8 +140,6 @@ checksum_file(const char src, pg_checksum_context checksum_ctx)`
`141`	`140`	`{`
`142`	`141`	`if (pg_checksum_update(checksum_ctx, buffer, rb) < 0)`
`143`	`142`	`pg_fatal("could not update checksum of file \"%s\"", src);`
`144`		`-`
`145`		`- offset += rb;`
`146`	`143`	`}`
`147`	`144`
`148`	`145`	`if (rb < 0)`