Avoid referencing Z_DEFAULT_COMPRESSION outside HAVE_LIBZ.

robertmhaas · robertmhaas · commit 8ee940843dfe · 2022-01-27T15:11:19.000-05:00
Because that's bad. Discussion: http://postgr.es/m/20220127174545.GV23027@telsasoft.com
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -1919,7 +1919,7 @@ BaseBackup(void)
 		}
 		AppendStringCommandOption(&buf, use_new_option_syntax,
 								  "COMPRESSION", compressmethodstr);
-		if (compresslevel != 0 && compresslevel != Z_DEFAULT_COMPRESSION)
+		if (compresslevel >= 1) /* not 0 or Z_DEFAULT_COMPRESSION */
 			AppendIntegerCommandOption(&buf, use_new_option_syntax,
 									   "COMPRESSION_LEVEL", compresslevel);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1919,7 +1919,7 @@ BaseBackup(void)`
`1919`	`1919`	`}`
`1920`	`1920`	`AppendStringCommandOption(&buf, use_new_option_syntax,`
`1921`	`1921`	`"COMPRESSION", compressmethodstr);`
`1922`		`- if (compresslevel != 0 && compresslevel != Z_DEFAULT_COMPRESSION)`
	`1922`	`+ if (compresslevel >= 1) /* not 0 or Z_DEFAULT_COMPRESSION */`
`1923`	`1923`	`AppendIntegerCommandOption(&buf, use_new_option_syntax,`
`1924`	`1924`	`"COMPRESSION_LEVEL", compresslevel);`
`1925`	`1925`	`}`