Use snprintf instead of sprintf in pg_regress.

danielgustafsson · danielgustafsson · commit 8f0fd47fa337 · 2023-10-25T10:53:11.000+02:00
To avoid static analyzers sounding the alarm, move to using snprintf instead of sprintf. This was an oversight in 66d6086. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/849588.1698179694@sss.pgh.pa.us
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
@@ -845,7 +845,7 @@ initialize_environment(void)
 		{
 			char		s[16];
 
-			sprintf(s, "%d", port);
+			snprintf(s, sizeof(s), "%d", port);
 			setenv("PGPORT", s, 1);
 		}
 	}
@@ -867,7 +867,7 @@ initialize_environment(void)
 		{
 			char		s[16];
 
-			sprintf(s, "%d", port);
+			snprintf(s, sizeof(s), "%d", port);
 			setenv("PGPORT", s, 1);
 		}
 		if (user != NULL)

Original file line number	Diff line number	Diff line change
`@@ -845,7 +845,7 @@ initialize_environment(void)`
`845`	`845`	`{`
`846`	`846`	`char s[16];`
`847`	`847`
`848`		`- sprintf(s, "%d", port);`
	`848`	`+ snprintf(s, sizeof(s), "%d", port);`
`849`	`849`	`setenv("PGPORT", s, 1);`
`850`	`850`	`}`
`851`	`851`	`}`
`@@ -867,7 +867,7 @@ initialize_environment(void)`
`867`	`867`	`{`
`868`	`868`	`char s[16];`
`869`	`869`
`870`		`- sprintf(s, "%d", port);`
	`870`	`+ snprintf(s, sizeof(s), "%d", port);`
`871`	`871`	`setenv("PGPORT", s, 1);`
`872`	`872`	`}`
`873`	`873`	`if (user != NULL)`