Fix ancient memory leak in PQprintTuples(); our code no longer uses this

tglsfdc · tglsfdc · commit 8f52496a05e8 · 2006-04-19T16:15:29.000Z
routine, but perhaps some applications do.  Found by Martijn van Oosterhout
using Coverity.
diff --git a/src/interfaces/libpq/fe-print.c b/src/interfaces/libpq/fe-print.c
@@ -10,7 +10,7 @@
  * didn't really belong there.
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-print.c,v 1.67 2006/03/05 15:59:09 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-print.c,v 1.68 2006/04/19 16:15:29 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -751,8 +751,10 @@ PQprintTuples(const PGresult *res,
 				fprintf(fout, "|\n%s\n", tborder);
 		}
 	}
-}
 
+	if (tborder)
+		free(tborder);
+}
 
 
 /* simply send out max-length number of filler characters to fp */

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* didn't really belong there.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-print.c,v 1.67 2006/03/05 15:59:09 momjian Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-print.c,v 1.68 2006/04/19 16:15:29 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -751,8 +751,10 @@ PQprintTuples(const PGresult *res,`
`751`	`751`	`fprintf(fout, "\|\n%s\n", tborder);`
`752`	`752`	`}`
`753`	`753`	`}`
`754`		`-}`
`755`	`754`
	`755`	`+ if (tborder)`
	`756`	`+ free(tborder);`
	`757`	`+}`
`756`	`758`
`757`	`759`
`758`	`760`	`/* simply send out max-length number of filler characters to fp */`