Silence nbtree.h cpluspluscheck warning.

petergeoghegan · petergeoghegan · commit 90051cd8278b · 2020-03-02T10:29:30.000-08:00
Add a cast to size_t to silence "comparison between signed and unsigned integer expressions" cpluspluscheck warning. Reported-By: Tom Lane Discussion: https://postgr.es/m/7971.1583171266@sss.pgh.pa.us
diff --git a/src/include/access/nbtree.h b/src/include/access/nbtree.h
@@ -381,7 +381,7 @@ static inline void
 BTreeTupleSetPosting(IndexTuple itup, int nhtids, int postingoffset)
 {
 	Assert(nhtids > 1 && (nhtids & BT_OFFSET_MASK) == nhtids);
-	Assert(postingoffset == MAXALIGN(postingoffset));
+	Assert((size_t) postingoffset == MAXALIGN(postingoffset));
 	Assert(postingoffset < INDEX_SIZE_MASK);
 
 	itup->t_info |= INDEX_ALT_TID_MASK;

Original file line number	Diff line number	Diff line change
`@@ -381,7 +381,7 @@ static inline void`
`381`	`381`	`BTreeTupleSetPosting(IndexTuple itup, int nhtids, int postingoffset)`
`382`	`382`	`{`
`383`	`383`	`Assert(nhtids > 1 && (nhtids & BT_OFFSET_MASK) == nhtids);`
`384`		`- Assert(postingoffset == MAXALIGN(postingoffset));`
	`384`	`+ Assert((size_t) postingoffset == MAXALIGN(postingoffset));`
`385`	`385`	`Assert(postingoffset < INDEX_SIZE_MASK);`
`386`	`386`
`387`	`387`	`itup->t_info \|= INDEX_ALT_TID_MASK;`