Commit 98640f9
committed
Fix memory leak in Incremental Sort rescans
The Incremental Sort had a couple issues, resulting in leaking memory
during rescans, possibly triggering OOM. The code had a couple of
related flaws:
1. During rescans, the sort states were reset but then also set to NULL
(despite the comment saying otherwise). ExecIncrementalSort then
sees NULL and initializes a new sort state, leaking the memory used
by the old one.
2. Initializing the sort state also automatically rebuilt the info about
presorted keys, leaking the already initialized info. presorted_keys
was also unnecessarily reset to NULL.
Patch by James Coleman, based on patches by Laurenz Albe and Tom Lane.
Backpatch to 13, where Incremental Sort was introduced.
Author: James Coleman, Laurenz Albe, Tom Lane
Reported-by: Laurenz Albe, Zu-Ming Jiang
Backpatch-through: 13
Discussion: https://postgr.es/m/b2bd02dff61af15e3526293e2771f874cf2a3be7.camel%40cybertec.at
Discussion: https://postgr.es/m/db03c582-086d-e7cd-d4a1-3bc722f81765%40inf.ethz.ch1 parent 0457109 commit 98640f9
1 file changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1140 | 1140 | | |
1141 | 1141 | | |
1142 | 1142 | | |
1143 | | - | |
1144 | 1143 | | |
1145 | 1144 | | |
1146 | 1145 | | |
| |||
1153 | 1152 | | |
1154 | 1153 | | |
1155 | 1154 | | |
1156 | | - | |
1157 | 1155 | | |
1158 | | - | |
1159 | | - | |
1160 | 1156 | | |
1161 | | - | |
1162 | 1157 | | |
1163 | | - | |
1164 | | - | |
1165 | 1158 | | |
1166 | 1159 | | |
1167 | 1160 | | |
| |||
0 commit comments