Revert "Rename contrib module basic_archive to basic_wal_module"

This reverts commit 0ad3c60, as per feedback from Tom Lane, Robert Haas
and Andres Freund.  The new name used for the module had little
support.

This moves back to basic_archive as module name, and we will likely use
that as template for recovery modules, as well.

Discussion: https://postgr.es/m/CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com

Author: michaelpq

contrib/Makefile

@@ -9,7 +9,7 @@ SUBDIRS = \
 		amcheck		\
 		auth_delay	\
 		auto_explain	\
-		basic_wal_module	\
+		basic_archive	\
 		basebackup_to_shell	\
 		bloom		\
 		btree_gin	\

contrib/basic_wal_module/.gitignore renamed to contrib/basic_archive/.gitignore

@@ -1,11 +1,11 @@
-# contrib/basic_wal_module/Makefile
+# contrib/basic_archive/Makefile
 
-MODULES = basic_wal_module
-PGFILEDESC = "basic_wal_module - basic write-ahead log module"
+MODULES = basic_archive
+PGFILEDESC = "basic_archive - basic archive module"
 
-REGRESS = basic_wal_module
-REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/basic_wal_module/basic_wal_module.conf
-# Disabled because these tests require "shared_preload_libraries=basic_wal_module",
+REGRESS = basic_archive
+REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/basic_archive/basic_archive.conf
+# Disabled because these tests require "shared_preload_libraries=basic_archive",
 # which typical installcheck users do not have (e.g. buildfarm clients).
 NO_INSTALLCHECK = 1
 
@@ -14,7 +14,7 @@ PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
 include $(PGXS)
 else
-subdir = contrib/basic_wal_module
+subdir = contrib/basic_archive
 top_builddir = ../..
 include $(top_builddir)/src/Makefile.global
 include $(top_srcdir)/contrib/contrib-global.mk

contrib/basic_wal_module/Makefile renamed to contrib/basic_archive/Makefile

@@ -1,6 +1,6 @@
 /*-------------------------------------------------------------------------
  *
- * basic_wal_module.c
+ * basic_archive.c
  *
  * This file demonstrates a basic archive library implementation that is
  * roughly equivalent to the following shell command:
@@ -20,7 +20,7 @@
  * Copyright (c) 2022-2023, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  contrib/basic_wal_module/basic_wal_module.c
+ *	  contrib/basic_archive/basic_archive.c
  *
  *-------------------------------------------------------------------------
  */
@@ -41,7 +41,7 @@
 PG_MODULE_MAGIC;
 
 static char *archive_directory = NULL;
-static MemoryContext basic_wal_module_context;
+static MemoryContext basic_archive_context;
 
 static bool basic_archive_configured(void);
 static bool basic_archive_file(const char *file, const char *path);
@@ -57,7 +57,7 @@ static bool compare_files(const char *file1, const char *file2);
 void
 _PG_init(void)
 {
-	DefineCustomStringVariable("basic_wal_module.archive_directory",
+	DefineCustomStringVariable("basic_archive.archive_directory",
 							   gettext_noop("Archive file destination directory."),
 							   NULL,
 							   &archive_directory,
@@ -66,11 +66,11 @@ _PG_init(void)
 							   0,
 							   check_archive_directory, NULL, NULL);
 
-	MarkGUCPrefixReserved("basic_wal_module");
+	MarkGUCPrefixReserved("basic_archive");
 
-	basic_wal_module_context = AllocSetContextCreate(TopMemoryContext,
-													 "basic_wal_module",
-													 ALLOCSET_DEFAULT_SIZES);
+	basic_archive_context = AllocSetContextCreate(TopMemoryContext,
+												  "basic_archive",
+												  ALLOCSET_DEFAULT_SIZES);
 }
 
 /*
@@ -156,7 +156,7 @@ basic_archive_file(const char *file, const char *path)
 	 * we can easily reset it during error recovery (thus avoiding memory
 	 * leaks).
 	 */
-	oldcontext = MemoryContextSwitchTo(basic_wal_module_context);
+	oldcontext = MemoryContextSwitchTo(basic_archive_context);
 
 	/*
 	 * Since the archiver operates at the bottom of the exception stack,
@@ -183,7 +183,7 @@ basic_archive_file(const char *file, const char *path)
 
 		/* Reset our memory context and switch back to the original one */
 		MemoryContextSwitchTo(oldcontext);
-		MemoryContextReset(basic_wal_module_context);
+		MemoryContextReset(basic_archive_context);
 
 		/* Remove our exception handler */
 		PG_exception_stack = NULL;
@@ -206,7 +206,7 @@ basic_archive_file(const char *file, const char *path)
 
 	/* Reset our memory context and switch back to the original one */
 	MemoryContextSwitchTo(oldcontext);
-	MemoryContextReset(basic_wal_module_context);
+	MemoryContextReset(basic_archive_context);
 
 	return true;
 }
@@ -221,7 +221,7 @@ basic_archive_file_internal(const char *file, const char *path)
 	uint64		epoch;			/* milliseconds */
 
 	ereport(DEBUG3,
-			(errmsg("archiving \"%s\" via basic_wal_module", file)));
+			(errmsg("archiving \"%s\" via basic_archive", file)));
 
 	snprintf(destination, MAXPGPATH, "%s/%s", archive_directory, file);
 
@@ -285,7 +285,7 @@ basic_archive_file_internal(const char *file, const char *path)
 	(void) durable_rename(temp, destination, ERROR);
 
 	ereport(DEBUG1,
-			(errmsg("archived \"%s\" via basic_wal_module", file)));
+			(errmsg("archived \"%s\" via basic_archive", file)));
 }
 
 /*

contrib/basic_wal_module/basic_wal_module.c renamed to contrib/basic_archive/basic_archive.c

@@ -0,0 +1,4 @@
+archive_mode = on
+archive_library = 'basic_archive'
+basic_archive.archive_directory = '.'
+wal_level = replica

contrib/basic_archive/basic_archive.conf

@@ -0,0 +1,34 @@
+# Copyright (c) 2022-2023, PostgreSQL Global Development Group
+
+basic_archive_sources = files(
+  'basic_archive.c',
+)
+
+if host_system == 'windows'
+  basic_archive_sources += rc_lib_gen.process(win32ver_rc, extra_args: [
+    '--NAME', 'basic_archive',
+    '--FILEDESC', 'basic_archive - basic archive module',])
+endif
+
+basic_archive = shared_module('basic_archive',
+  basic_archive_sources,
+  kwargs: contrib_mod_args,
+)
+contrib_targets += basic_archive
+
+tests += {
+  'name': 'basic_archive',
+  'sd': meson.current_source_dir(),
+  'bd': meson.current_build_dir(),
+  'regress': {
+    'sql': [
+      'basic_archive',
+    ],
+    'regress_args': [
+      '--temp-config', files('basic_archive.conf'),
+    ],
+    # Disabled because these tests require "shared_preload_libraries=basic_archive",
+    # which typical runningcheck users do not have (e.g. buildfarm clients).
+    'runningcheck': false,
+  },
+}