Remove unnecessary check for NULL locale, per Coverity.

jeff-davis · jeff-davis · commit a459ac504cc6 · 2024-08-12T12:26:23.000-07:00
Discussion: https://postgr.es/m/3804933.1723394010@sss.pgh.pa.us Reported-by: Tom Lane
diff --git a/src/backend/utils/adt/like.c b/src/backend/utils/adt/like.c
@@ -201,7 +201,7 @@ Generic_Text_IC_like(text *str, text *pat, Oid collation)
 	 * way.
 	 */
 
-	if (pg_database_encoding_max_length() > 1 || (locale && locale->provider == COLLPROVIDER_ICU))
+	if (pg_database_encoding_max_length() > 1 || (locale->provider == COLLPROVIDER_ICU))
 	{
 		pat = DatumGetTextPP(DirectFunctionCall1Coll(lower, collation,
 													 PointerGetDatum(pat)));

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ Generic_Text_IC_like(text str, text pat, Oid collation)`
`201`	`201`	`* way.`
`202`	`202`	`*/`
`203`	`203`
`204`		`- if (pg_database_encoding_max_length() > 1 \|\| (locale && locale->provider == COLLPROVIDER_ICU))`
	`204`	`+ if (pg_database_encoding_max_length() > 1 \|\| (locale->provider == COLLPROVIDER_ICU))`
`205`	`205`	`{`
`206`	`206`	`pat = DatumGetTextPP(DirectFunctionCall1Coll(lower, collation,`
`207`	`207`	`PointerGetDatum(pat)));`