Remove redundant variable pageSize in gistinitpage

petere · petere · commit a60c4c5c1a99 · 2021-06-25T07:55:34.000+02:00
In gistinitpage, pageSize variable looks redundant, instead just pass BLCKSZ. This will be consistent with its peers BloomInitPage, brin_page_init and SpGistInitPage. Author: Bharath Rupireddy <bharath.rupireddy@enterprisedb.com> Discussion: https://www.postgresql.org/message-id/flat/CALj2ACWj=V1k5591eeZK2sOg2FYuBUp6azFO8tMkBtGfXf8PMQ@mail.gmail.com
diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c
@@ -756,9 +756,8 @@ void
 gistinitpage(Page page, uint32 f)
 {
 	GISTPageOpaque opaque;
-	Size		pageSize = BLCKSZ;
 
-	PageInit(page, pageSize, sizeof(GISTPageOpaqueData));
+	PageInit(page, BLCKSZ, sizeof(GISTPageOpaqueData));
 
 	opaque = GistPageGetOpaque(page);
 	opaque->rightlink = InvalidBlockNumber;

Original file line number	Diff line number	Diff line change
`@@ -756,9 +756,8 @@ void`
`756`	`756`	`gistinitpage(Page page, uint32 f)`
`757`	`757`	`{`
`758`	`758`	`GISTPageOpaque opaque;`
`759`		`- Size pageSize = BLCKSZ;`
`760`	`759`
`761`		`- PageInit(page, pageSize, sizeof(GISTPageOpaqueData));`
	`760`	`+ PageInit(page, BLCKSZ, sizeof(GISTPageOpaqueData));`
`762`	`761`
`763`	`762`	`opaque = GistPageGetOpaque(page);`
`764`	`763`	`opaque->rightlink = InvalidBlockNumber;`