pg_rewind: Close backup_label file descriptor.

anarazel · anarazel · commit a6c845946dac · 2016-03-27T22:48:31.000+02:00
This was a relatively harmless leak, as createBackupLabel() is only
called once per pg_rewind invocation.

Author: Michael Paquier
Reported-By: Michael Paquier
Discussion: CAB7nPqRnOw30gOXe2_SPLjh37bgm4V+txbYAPwoXb97nGQ297w@mail.gmail.com
Backpatch: 9.5, where pg_rewind was introduced
diff --git a/src/bin/pg_rewind/pg_rewind.c b/src/bin/pg_rewind/pg_rewind.c
@@ -584,6 +584,7 @@ createBackupLabel(XLogRecPtr startpoint, TimeLineID starttli, XLogRecPtr checkpo
 	/* TODO: move old file out of the way, if any. */
 	open_target_file("backup_label", true);		/* BACKUP_LABEL_FILE */
 	write_target_range(buf, 0, len);
+	close_target_file();
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -584,6 +584,7 @@ createBackupLabel(XLogRecPtr startpoint, TimeLineID starttli, XLogRecPtr checkpo`
`584`	`584`	`/* TODO: move old file out of the way, if any. */`
`585`	`585`	`open_target_file("backup_label", true); /* BACKUP_LABEL_FILE */`
`586`	`586`	`write_target_range(buf, 0, len);`
	`587`	`+ close_target_file();`
`587`	`588`	`}`
`588`	`589`
`589`	`590`	`/*`