Avoid file descriptor leak in pg_test_fsync.

robertmhaas · robertmhaas · commit a855c90a72d2 · 2014-11-19T12:26:06.000-05:00
This can cause problems on Windows, where files that are still open
can't be unlinked.

Jeff Janes
diff --git a/contrib/pg_test_fsync/pg_test_fsync.c b/contrib/pg_test_fsync/pg_test_fsync.c
@@ -206,8 +206,6 @@ test_sync(int writes_per_op)
 	}
 	else
 	{
-		if ((tmpfile = open(filename, O_RDWR | O_DSYNC | PG_O_DIRECT, 0)) == -1)
-			die("could not open output file");
 		gettimeofday(&start_t, NULL);
 		for (ops = 0; ops < ops_per_test; ops++)
 		{

Original file line number	Diff line number	Diff line change
`@@ -206,8 +206,6 @@ test_sync(int writes_per_op)`
`206`	`206`	`}`
`207`	`207`	`else`
`208`	`208`	`{`
`209`		`- if ((tmpfile = open(filename, O_RDWR \| O_DSYNC \| PG_O_DIRECT, 0)) == -1)`
`210`		`- die("could not open output file");`
`211`	`209`	`gettimeofday(&start_t, NULL);`
`212`	`210`	`for (ops = 0; ops < ops_per_test; ops++)`
`213`	`211`	`{`