compatible_oper needs to do ReleaseSysCache in one path to avoid

tglsfdc · tglsfdc · commit a933bceacfbb · 2001-04-23T04:32:30.000Z
complaints about 'Cache reference leak'.  Per report from Don Baccus.
diff --git a/src/backend/parser/parse_oper.c b/src/backend/parser/parse_oper.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.48 2001/03/22 03:59:41 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.49 2001/04/23 04:32:30 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -686,6 +686,9 @@ compatible_oper(char *op, Oid arg1, Oid arg2, bool noError)
 		 IS_BINARY_COMPATIBLE(opform->oprright, arg2)))
 		return optup;
 
+	/* nope... */
+	ReleaseSysCache(optup);
+
 	if (!noError)
 		op_error(op, arg1, arg2);
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.48 2001/03/22 03:59:41 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.49 2001/04/23 04:32:30 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -686,6 +686,9 @@ compatible_oper(char *op, Oid arg1, Oid arg2, bool noError)`
`686`	`686`	`IS_BINARY_COMPATIBLE(opform->oprright, arg2)))`
`687`	`687`	`return optup;`
`688`	`688`
	`689`	`+ /* nope... */`
	`690`	`+ ReleaseSysCache(optup);`
	`691`	`+`
`689`	`692`	`if (!noError)`
`690`	`693`	`op_error(op, arg1, arg2);`
`691`	`694`