pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid

tglsfdc · tglsfdc · commit ac7df108cf32 · 2022-01-23T13:54:24.000-05:00
Commit 6df7a96 wrote appendPQExpBuffer where it should have written printfPQExpBuffer. This resulted in re-issuing the previous query along with the desired one, which very accidentally had no negative consequences except for some wasted cycles. Back-patch to v14 where that came in. Discussion: https://postgr.es/m/1714711.1642962663@sss.pgh.pa.us
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -4574,7 +4574,7 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout,
 	{
 		if (fout->remoteVersion >= 140000)
 		{
-			appendPQExpBuffer(upgrade_query,
+			printfPQExpBuffer(upgrade_query,
 							  "SELECT t.oid, t.typarray "
 							  "FROM pg_catalog.pg_type t "
 							  "JOIN pg_catalog.pg_range r "

Original file line number	Diff line number	Diff line change
`@@ -4574,7 +4574,7 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout,`
`4574`	`4574`	`{`
`4575`	`4575`	`if (fout->remoteVersion >= 140000)`
`4576`	`4576`	`{`
`4577`		`- appendPQExpBuffer(upgrade_query,`
	`4577`	`+ printfPQExpBuffer(upgrade_query,`
`4578`	`4578`	`"SELECT t.oid, t.typarray "`
`4579`	`4579`	`"FROM pg_catalog.pg_type t "`
`4580`	`4580`	`"JOIN pg_catalog.pg_range r "`