Fix assorted inconsistent function declarations.

tglsfdc · tglsfdc · commit b1145ca19819 · 2015-04-07T16:56:21.000-04:00
While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
@@ -294,7 +294,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -1147,7 +1147,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`294`	`294`	`}`
`295`	`295`	`#endif`
`296`	`296`
`297`		`-void`
	`297`	`+static void`
`298`	`298`	`get_restricted_token(const char *progname)`
`299`	`299`	`{`
`300`	`300`	`#ifdef WIN32`
Original file line number	Diff line number	Diff line change
`@@ -1147,7 +1147,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`1147`	`1147`	`}`
`1148`	`1148`	`#endif`
`1149`	`1149`
`1150`		`-void`
	`1150`	`+static void`
`1151`	`1151`	`get_restricted_token(const char *progname)`
`1152`	`1152`	`{`
`1153`	`1153`	`#ifdef WIN32`