Don't use SGML empty tags

For DocBook XML compatibility, don't use SGML empty tags (</>) anymore,
replace by the full tag name.  Add a warning option to catch future
occurrences.

Alexander Lakhin, Jürgen Purtz

Author: petere

doc/src/sgml/Makefile

@@ -66,10 +66,11 @@ ALLSGML := $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) $(GENERATED_SGML)
 # Enable some extra warnings
 # -wfully-tagged needed to throw a warning on missing tags
 # for older tool chains, 2007-08-31
-override SPFLAGS += -wall -wno-unused-param -wno-empty -wfully-tagged
+override SPFLAGS += -wall -wno-unused-param -wfully-tagged
 # Additional warnings for XML compatibility.  The conditional is meant
 # to detect whether we are using OpenSP rather than the ancient
 # original SP.
+override SPFLAGS += -wempty
 ifneq (,$(filter o%,$(notdir $(OSX))))
 override SPFLAGS += -wdata-delim -winstance-ignore-ms -winstance-include-ms -winstance-param-entity
 endif

doc/src/sgml/acronyms.sgml

@@ -4,8 +4,8 @@
  <title>Acronyms</title>
 
  <para>
-  This is a list of acronyms commonly used in the <productname>PostgreSQL</>
-  documentation and in discussions about <productname>PostgreSQL</>.
+  This is a list of acronyms commonly used in the <productname>PostgreSQL</productname>
+  documentation and in discussions about <productname>PostgreSQL</productname>.
 
   <variablelist>
 
@@ -153,7 +153,7 @@
       <ulink
       url="http://en.wikipedia.org/wiki/Data_Definition_Language">Data
       Definition Language</ulink>, SQL commands such as <command>CREATE
-      TABLE</>, <command>ALTER USER</>
+      TABLE</command>, <command>ALTER USER</command>
      </para>
     </listitem>
    </varlistentry>
@@ -164,8 +164,8 @@
      <para>
       <ulink
       url="http://en.wikipedia.org/wiki/Data_Manipulation_Language">Data
-      Manipulation Language</ulink>, SQL commands such as <command>INSERT</>,
-      <command>UPDATE</>, <command>DELETE</>
+      Manipulation Language</ulink>, SQL commands such as <command>INSERT</command>,
+      <command>UPDATE</command>, <command>DELETE</command>
      </para>
     </listitem>
    </varlistentry>
@@ -281,7 +281,7 @@
     <listitem>
      <para>
       <link linkend="config-setting">Grand Unified Configuration</link>,
-      the <productname>PostgreSQL</> subsystem that handles server configuration
+      the <productname>PostgreSQL</productname> subsystem that handles server configuration
      </para>
     </listitem>
    </varlistentry>
@@ -384,7 +384,7 @@
     <term><acronym>LSN</acronym></term>
     <listitem>
      <para>
-      Log Sequence Number, see <link linkend="datatype-pg-lsn"><type>pg_lsn</></link>
+      Log Sequence Number, see <link linkend="datatype-pg-lsn"><type>pg_lsn</type></link>
       and <link linkend="wal-internals">WAL Internals</link>.
      </para>
     </listitem>
@@ -486,7 +486,7 @@
     <term><acronym>PGSQL</acronym></term>
     <listitem>
      <para>
-      <link linkend="postgres"><productname>PostgreSQL</></link>
+      <link linkend="postgres"><productname>PostgreSQL</productname></link>
      </para>
     </listitem>
    </varlistentry>
@@ -495,7 +495,7 @@
     <term><acronym>PGXS</acronym></term>
     <listitem>
      <para>
-      <link linkend="extend-pgxs"><productname>PostgreSQL</> Extension System</link>
+      <link linkend="extend-pgxs"><productname>PostgreSQL</productname> Extension System</link>
      </para>
     </listitem>
    </varlistentry>

doc/src/sgml/adminpack.sgml

@@ -8,8 +8,8 @@
  </indexterm>
 
  <para>
-  <filename>adminpack</> provides a number of support functions which
-  <application>pgAdmin</> and other administration and management tools can
+  <filename>adminpack</filename> provides a number of support functions which
+  <application>pgAdmin</application> and other administration and management tools can
   use to provide additional functionality, such as remote management
   of server log files.
   Use of all these functions is restricted to superusers.
@@ -25,7 +25,7 @@
  </para>
 
  <table id="functions-adminpack-table">
-  <title><filename>adminpack</> Functions</title>
+  <title><filename>adminpack</filename> Functions</title>
   <tgroup cols="3">
    <thead>
     <row><entry>Name</entry> <entry>Return Type</entry> <entry>Description</entry>
@@ -58,7 +58,7 @@
      <entry><function>pg_catalog.pg_logdir_ls()</function></entry>
      <entry><type>setof record</type></entry>
      <entry>
-      List the log files in the <varname>log_directory</> directory
+      List the log files in the <varname>log_directory</varname> directory
      </entry>
     </row>
    </tbody>
@@ -69,9 +69,9 @@
   <primary>pg_file_write</primary>
  </indexterm>
  <para>
-  <function>pg_file_write</> writes the specified <parameter>data</> into
-  the file named by <parameter>filename</>.  If <parameter>append</> is
-  false, the file must not already exist.  If <parameter>append</> is true,
+  <function>pg_file_write</function> writes the specified <parameter>data</parameter> into
+  the file named by <parameter>filename</parameter>.  If <parameter>append</parameter> is
+  false, the file must not already exist.  If <parameter>append</parameter> is true,
   the file can already exist, and will be appended to if so.
   Returns the number of bytes written.
  </para>
@@ -80,15 +80,15 @@
   <primary>pg_file_rename</primary>
  </indexterm>
  <para>
-  <function>pg_file_rename</> renames a file.  If <parameter>archivename</>
-  is omitted or NULL, it simply renames <parameter>oldname</>
-  to <parameter>newname</> (which must not already exist).
-  If <parameter>archivename</> is provided, it first
-  renames <parameter>newname</> to <parameter>archivename</> (which must
-  not already exist), and then renames <parameter>oldname</>
-  to <parameter>newname</>.  In event of failure of the second rename step,
-  it will try to rename <parameter>archivename</> back
-  to <parameter>newname</> before reporting the error.
+  <function>pg_file_rename</function> renames a file.  If <parameter>archivename</parameter>
+  is omitted or NULL, it simply renames <parameter>oldname</parameter>
+  to <parameter>newname</parameter> (which must not already exist).
+  If <parameter>archivename</parameter> is provided, it first
+  renames <parameter>newname</parameter> to <parameter>archivename</parameter> (which must
+  not already exist), and then renames <parameter>oldname</parameter>
+  to <parameter>newname</parameter>.  In event of failure of the second rename step,
+  it will try to rename <parameter>archivename</parameter> back
+  to <parameter>newname</parameter> before reporting the error.
   Returns true on success, false if the source file(s) are not present or
   not writable; other cases throw errors.
  </para>
@@ -97,19 +97,19 @@
   <primary>pg_file_unlink</primary>
  </indexterm>
  <para>
-  <function>pg_file_unlink</> removes the specified file.
+  <function>pg_file_unlink</function> removes the specified file.
   Returns true on success, false if the specified file is not present
-  or the <function>unlink()</> call fails; other cases throw errors.
+  or the <function>unlink()</function> call fails; other cases throw errors.
  </para>
 
  <indexterm>
   <primary>pg_logdir_ls</primary>
  </indexterm>
  <para>
-  <function>pg_logdir_ls</> returns the start timestamps and path
+  <function>pg_logdir_ls</function> returns the start timestamps and path
   names of all the log files in the <xref linkend="guc-log-directory">
   directory.  The <xref linkend="guc-log-filename"> parameter must have its
-  default setting (<literal>postgresql-%Y-%m-%d_%H%M%S.log</>) to use this
+  default setting (<literal>postgresql-%Y-%m-%d_%H%M%S.log</literal>) to use this
   function.
  </para>
 
@@ -119,12 +119,12 @@
   and should not be used in new applications; instead use those shown
   in <xref linkend="functions-admin-signal-table">
   and <xref linkend="functions-admin-genfile-table">.  These functions are
-  provided in <filename>adminpack</> only for compatibility with old
-  versions of <application>pgAdmin</>.
+  provided in <filename>adminpack</filename> only for compatibility with old
+  versions of <application>pgAdmin</application>.
  </para>
 
  <table id="functions-adminpack-deprecated-table">
-  <title>Deprecated <filename>adminpack</> Functions</title>
+  <title>Deprecated <filename>adminpack</filename> Functions</title>
   <tgroup cols="3">
    <thead>
     <row><entry>Name</entry> <entry>Return Type</entry> <entry>Description</entry>
@@ -136,22 +136,22 @@
      <entry><function>pg_catalog.pg_file_read(filename text, offset bigint, nbytes bigint)</function></entry>
      <entry><type>text</type></entry>
      <entry>
-      Alternate name for <function>pg_read_file()</>
+      Alternate name for <function>pg_read_file()</function>
      </entry>
     </row>
     <row>
      <entry><function>pg_catalog.pg_file_length(filename text)</function></entry>
      <entry><type>bigint</type></entry>
      <entry>
-      Same as <structfield>size</> column returned
-      by <function>pg_stat_file()</>
+      Same as <structfield>size</structfield> column returned
+      by <function>pg_stat_file()</function>
      </entry>
     </row>
     <row>
      <entry><function>pg_catalog.pg_logfile_rotate()</function></entry>
      <entry><type>integer</type></entry>
      <entry>
-      Alternate name for <function>pg_rotate_logfile()</>, but note that it
+      Alternate name for <function>pg_rotate_logfile()</function>, but note that it
       returns integer 0 or 1 rather than <type>boolean</type>
      </entry>
     </row>