Significant cleanups in SysV IPC handling (shared mem and semaphores).

IPC key assignment will now work correctly even when multiple postmasters
are using same logical port number (which is possible given -k switch).
There is only one shared-mem segment per postmaster now, not 3.
Rip out broken code for non-TAS case in bufmgr and xlog, substitute a
complete S_LOCK emulation using semaphores in spin.c.  TAS and non-TAS
logic is now exactly the same.
When deadlock is detected, "Deadlock detected" is now the elog(ERROR)
message, rather than a NOTICE that comes out before an unhelpful ERROR.

Author: tglsfdc

doc/src/sgml/ref/postmaster.sgml

@@ -1,5 +1,5 @@
 <!--
-$Header: /cvsroot/pgsql/doc/src/sgml/ref/postmaster.sgml,v 1.16 2000/11/22 01:41:13 momjian Exp $
+$Header: /cvsroot/pgsql/doc/src/sgml/ref/postmaster.sgml,v 1.17 2000/11/28 23:27:54 tgl Exp $
 Postgres documentation
 -->
 
@@ -400,32 +400,6 @@ $ ps -e | grep postmast
        </para>
       </listitem>
      </varlistentry>
-
-     <varlistentry>
-      <term><computeroutput>
-IpcMemoryAttach: shmat() failed: Permission denied
-       </computeroutput></term>
-      <listitem>
-       <para>
-	A likely explanation is that another user attempted to start a
-	<application>postmaster</application>
-	process on the same port which acquired shared resources and then 
-	died.  Since Postgres shared memory keys are based on the port number 
-	assigned to the
-	<application>postmaster</application>,
-	such conflicts are likely if there is more than one installation on 
-	a single host.  If there are no other
-	<application>postmaster</application>
-	processes currently running (see above), run
-	<application>ipcclean</application>
-	and try again.  If other <application>postmaster</application>
-	images
-	are running, you will have to find the owners of those processes to
-	coordinate the assignment of port numbers and/or removal of unused
-	shared memory segments.
-       </para>
-      </listitem>
-     </varlistentry>
     </variablelist>
    </para>
   </refsect2>

src/backend/access/transam/xlog.c

@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.35 2000/11/27 05:36:12 tgl Exp $
+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.36 2000/11/28 23:27:54 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -85,12 +85,6 @@ typedef struct XLogCtlWrite
 } XLogCtlWrite;
 
 
-#ifndef HAS_TEST_AND_SET
-#define TAS(lck)		0
-#define S_UNLOCK(lck)
-#define S_INIT_LOCK(lck)
-#endif
-
 typedef struct XLogCtlData
 {
 	XLogCtlInsert	Insert;
@@ -102,12 +96,10 @@ typedef struct XLogCtlData
 	uint32			XLogCacheByte;
 	uint32			XLogCacheBlck;
 	StartUpID		ThisStartUpID;
-#ifdef HAS_TEST_AND_SET
 	slock_t			insert_lck;
 	slock_t			info_lck;
 	slock_t			lgwr_lck;
 	slock_t			chkp_lck;		/* checkpoint lock */
-#endif
 } XLogCtlData;
 
 static XLogCtlData *XLogCtl = NULL;

src/backend/commands/async.c

@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/async.c,v 1.72 2000/11/21 21:15:59 petere Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/async.c,v 1.73 2000/11/28 23:27:54 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -119,8 +119,8 @@ static Dllist *pendingNotifies = NULL;
 static volatile int notifyInterruptEnabled = 0;
 static volatile int notifyInterruptOccurred = 0;
 
-/* True if we've registered an on_shmem_exit cleanup (or at least tried to). */
-static int	unlistenExitRegistered = 0;
+/* True if we've registered an on_shmem_exit cleanup */
+static bool unlistenExitRegistered = false;
 
 
 static void Async_UnlistenAll(void);
@@ -253,9 +253,8 @@ Async_Listen(char *relname, int pid)
 	 */
 	if (!unlistenExitRegistered)
 	{
-		if (on_shmem_exit(Async_UnlistenOnExit, 0) < 0)
-			elog(NOTICE, "Async_Listen: out of shmem_exit slots");
-		unlistenExitRegistered = 1;
+		on_shmem_exit(Async_UnlistenOnExit, 0);
+		unlistenExitRegistered = true;
 	}
 }
 

src/backend/postmaster/postmaster.c

@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.193 2000/11/27 04:03:20 inoue Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.194 2000/11/28 23:27:55 tgl Exp $
  *
  * NOTES
  *
@@ -117,26 +117,6 @@ int PostPortNumber;
 char * UnixSocketDir;
 char * Virtual_host;
 
-/*
- * This is a sequence number that indicates how many times we've had to
- * throw away the shared memory and start over because we doubted its
- * integrity.	It starts off at zero and is incremented every time we
- * start over.  We use this to ensure that we use a new IPC shared memory
- * key for the new shared memory segment in case the old segment isn't
- * entirely gone yet.
- *
- * The sequence actually cycles back to 0 after 9, so pathologically there
- * could be an IPC failure if 10 sets of backends are all stuck and won't
- * release IPC resources.
- */
-static short shmem_seq = 0;
-
-/*
- * This is the base IPC shared memory key.  Other keys are generated by
- * adding to this.
- */
-static IpcMemoryKey ipc_key;
-
 /*
  * MaxBackends is the actual limit on the number of backends we will
  * start. The default is established by configure, but it can be
@@ -1292,39 +1272,6 @@ ConnFree(Port *conn)
 	free(conn);
 }
 
-/*
- * get_host_port -- return a pseudo port number (16 bits)
- * derived from the primary IP address of Virtual_host.
- */
-static unsigned short
-get_host_port(void)
-{
-	static unsigned short hostPort = 0;
-
-	if (hostPort == 0)
-	{
-		SockAddr	saddr;
-		struct hostent *hp;
-
-		hp = gethostbyname(Virtual_host);
-		if ((hp == NULL) || (hp->h_addrtype != AF_INET))
-		{
-			char msg[1024];
-			snprintf(msg, sizeof(msg),
-				 "FATAL: get_host_port: gethostbyname(%s) failed\n",
-				 Virtual_host);
-			fputs(msg, stderr);
-			pqdebug("%s", msg);
-			exit(1);
-		}
-		memmove((char *) &(saddr.in.sin_addr),
-			(char *) hp->h_addr,
-			hp->h_length);
-		hostPort = ntohl(saddr.in.sin_addr.s_addr) & 0xFFFF;
-	}
-
-	return hostPort;
-}
 
 /*
  * reset_shared -- reset shared memory and semaphores
@@ -1333,40 +1280,16 @@ static void
 reset_shared(unsigned short port)
 {
 	/*
-	 * A typical ipc_key is 5432001, which is port 5432, sequence
-	 * number 0, and 01 as the index in IPCKeyGetBufferMemoryKey().
-	 * The 32-bit INT_MAX is 2147483 6 47.
-	 *
-	 * The default algorithm for calculating the IPC keys assumes that all
-	 * instances of postmaster on a given host are listening on different
-	 * ports.  In order to work (prevent shared memory collisions) if you
-	 * run multiple PostgreSQL instances on the same port and different IP
-	 * addresses on a host, we change the algorithm if you give postmaster
-	 * the -h option, or set PGHOST, to a value other than the internal
-	 * default.
-	 *
-	 * If Virtual_host is set, then we generate the IPC keys using the
-	 * last two octets of the IP address instead of the port number.
-	 * This algorithm assumes that no one will run multiple PostgreSQL
-	 * instances on one host using two IP addresses that have the same two
-	 * last octets in different class C networks.  If anyone does, it
-	 * would be rare.
-	 *
-	 * So, if you use -h or PGHOST, don't try to run two instances of
-	 * PostgreSQL on the same IP address but different ports.  If you
-	 * don't use them, then you must use different ports (via -p or
-	 * PGPORT).  And, of course, don't try to use both approaches on one
-	 * host.
+	 * Reset assignment of shared mem and semaphore IPC keys.
+	 * Doing this means that in normal cases we'll assign the same keys
+	 * on each "cycle of life", and thereby avoid leaving dead IPC objects
+	 * floating around if the postmaster crashes and is restarted.
 	 */
-
-	if (Virtual_host[0] != '\0')
-		port = get_host_port();
-
-	ipc_key = port * 1000 + shmem_seq * 100;
-	CreateSharedMemoryAndSemaphores(ipc_key, MaxBackends);
-	shmem_seq += 1;
-	if (shmem_seq >= 10)
-		shmem_seq -= 10;
+	IpcInitKeyAssignment(port);
+	/*
+	 * Create or re-create shared memory and semaphores.
+	 */
+	CreateSharedMemoryAndSemaphores(false, MaxBackends);
 }
 
 

src/backend/storage/buffer/buf_init.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/storage/buffer/buf_init.c,v 1.37 2000/10/23 04:10:06 vadim Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/storage/buffer/buf_init.c,v 1.38 2000/11/28 23:27:55 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -56,13 +56,6 @@ int			Num_Descriptors;
 BufferDesc *BufferDescriptors;
 BufferBlock BufferBlocks;
 
-#ifndef HAS_TEST_AND_SET
-long	   *NWaitIOBackendP;
-
-#endif
-
-extern IpcSemaphoreId WaitIOSemId;
-
 long	   *PrivateRefCount;	/* also used in freelist.c */
 bits8	   *BufferLocks;		/* flag bits showing locks I have set */
 BufferTag  *BufferTagLastDirtied;		/* tag buffer had when last
@@ -139,7 +132,7 @@ long int	LocalBufferFlushCount;
  * amount of available memory.
  */
 void
-InitBufferPool(IPCKey key)
+InitBufferPool(void)
 {
 	bool		foundBufs,
 				foundDescs;
@@ -170,18 +163,6 @@ InitBufferPool(IPCKey key)
 		ShmemInitStruct("Buffer Blocks",
 						NBuffers * BLCKSZ, &foundBufs);
 
-#ifndef HAS_TEST_AND_SET
-	{
-		bool		foundNWaitIO;
-
-		NWaitIOBackendP = (long *) ShmemInitStruct("#Backends Waiting IO",
-												   sizeof(long),
-												   &foundNWaitIO);
-		if (!foundNWaitIO)
-			*NWaitIOBackendP = 0;
-	}
-#endif
-
 	if (foundDescs || foundBufs)
 	{
 
@@ -214,10 +195,8 @@ InitBufferPool(IPCKey key)
 			buf->flags = (BM_DELETED | BM_FREE | BM_VALID);
 			buf->refcount = 0;
 			buf->buf_id = i;
-#ifdef HAS_TEST_AND_SET
 			S_INIT_LOCK(&(buf->io_in_progress_lock));
 			S_INIT_LOCK(&(buf->cntx_lock));
-#endif
 		}
 
 		/* close the circular queue */
@@ -231,22 +210,6 @@ InitBufferPool(IPCKey key)
 
 	SpinRelease(BufMgrLock);
 
-#ifndef HAS_TEST_AND_SET
-	{
-		extern IpcSemaphoreId WaitIOSemId;
-		extern IpcSemaphoreId WaitCLSemId;
-
-		WaitIOSemId = IpcSemaphoreCreate(IPCKeyGetWaitIOSemaphoreKey(key),
-										 1, IPCProtection, 0, 1);
-		if (WaitIOSemId < 0)
-			elog(FATAL, "InitBufferPool: IpcSemaphoreCreate(WaitIOSemId) failed");
-		WaitCLSemId = IpcSemaphoreCreate(IPCKeyGetWaitCLSemaphoreKey(key),
-										 1, IPCProtection,
-									   IpcSemaphoreDefaultStartValue, 1);
-		if (WaitCLSemId < 0)
-			elog(FATAL, "InitBufferPool: IpcSemaphoreCreate(WaitCLSemId) failed");
-	}
-#endif
 	PrivateRefCount = (long *) calloc(NBuffers, sizeof(long));
 	BufferLocks = (bits8 *) calloc(NBuffers, sizeof(bits8));
 	BufferTagLastDirtied = (BufferTag *) calloc(NBuffers, sizeof(BufferTag));
@@ -262,7 +225,7 @@ InitBufferPool(IPCKey key)
  * ----------------------------------------------------
  */
 int
-BufferShmemSize()
+BufferShmemSize(void)
 {
 	int			size = 0;