Fix failure with pgperlcritic from the TAP test of synchronous replication

michaelpq · michaelpq · commit c8e177f0bba6 · 2019-07-25T07:55:23.000+09:00
Oversight in 7d81bdc, which introduced a new routine in perl lacking a return clause. Per buildfarm member crake. Backpatch down to 9.6 like its parent. Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com Backpatch-through: 9.6
diff --git a/src/test/recovery/t/007_sync_rep.pl b/src/test/recovery/t/007_sync_rep.pl
@@ -42,6 +42,7 @@ sub start_standby_and_wait
 
 	print("### Waiting for standby \"$standby_name\" on \"$master_name\"\n");
 	$master->poll_query_until('postgres', $query);
+	return;
 }
 
 # Initialize master node

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ sub start_standby_and_wait`
`42`	`42`
`43`	`43`	`print("### Waiting for standby \"$standby_name\" on \"$master_name\"\n");`
`44`	`44`	`$master->poll_query_until('postgres', $query);`
	`45`	`+ return;`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`# Initialize master node`