Remove duplicated assignment of LLVMJitHandle->lljit

michaelpq · michaelpq · commit ccfca8ea42b8 · 2023-07-13T16:44:17.000+09:00
This duplicated assignment when emiting some code not yet compiled. Oversight in 6c57f2e. Author: Matheus Alcantara Reviewed-by: Gurjeet Singh Discussion: https://postgr.es/m/La1Tfi7wirg9uGbCx_y7Qb9kl2T15mYouDXjCKAFuDqzQWnTRwH7KNLGigLLcxRs91V6dp2ySs1j_7mB4btzEZJ9NIMEAyOjUyAS7Jx-ydQ=@pm.me
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
@@ -722,8 +722,6 @@ llvm_compile_module(LLVMJitContext *context)
 			elog(ERROR, "failed to JIT module: %s",
 				 llvm_error_message(error));
 
-		handle->lljit = compile_orc;
-
 		/* LLVMOrcLLJITAddLLVMIRModuleWithRT takes ownership of the module */
 	}
 #elif LLVM_VERSION_MAJOR > 6

Original file line number	Diff line number	Diff line change
`@@ -722,8 +722,6 @@ llvm_compile_module(LLVMJitContext *context)`
`722`	`722`	`elog(ERROR, "failed to JIT module: %s",`
`723`	`723`	`llvm_error_message(error));`
`724`	`724`
`725`		`- handle->lljit = compile_orc;`
`726`		`-`
`727`	`725`	`/* LLVMOrcLLJITAddLLVMIRModuleWithRT takes ownership of the module */`
`728`	`726`	`}`
`729`	`727`	`#elif LLVM_VERSION_MAJOR > 6`