Fix under-parenthesized macro definitions

alvherre · alvherre · commit ce5d04b6463d · 2019-09-13T16:26:55.000-03:00
Lack of parens in the definitions could cause a statement using these macros to have unexpected semantics. In current code no bug is apparent, but best to fix the definitions to avoid problems down the line. Reported-by: Tom Lane Discussion: https://postgr.es/m/19795.1568400476@sss.pgh.pa.us
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
@@ -3312,8 +3312,8 @@ typedef struct ConstraintsSetStmt
  */
 
 /* Reindex options */
-#define REINDEXOPT_VERBOSE 1 << 0	/* print progress info */
-#define REINDEXOPT_REPORT_PROGRESS 1 << 1	/* report pgstat progress */
+#define REINDEXOPT_VERBOSE (1 << 0)	/* print progress info */
+#define REINDEXOPT_REPORT_PROGRESS (1 << 1)	/* report pgstat progress */
 
 typedef enum ReindexObjectType
 {

Original file line number	Diff line number	Diff line change
`@@ -3312,8 +3312,8 @@ typedef struct ConstraintsSetStmt`
`3312`	`3312`	`*/`
`3313`	`3313`
`3314`	`3314`	`/* Reindex options */`
`3315`		`-#define REINDEXOPT_VERBOSE 1 << 0 /* print progress info */`
`3316`		`-#define REINDEXOPT_REPORT_PROGRESS 1 << 1 /* report pgstat progress */`
	`3315`	`+#define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */`
	`3316`	`+#define REINDEXOPT_REPORT_PROGRESS (1 << 1) /* report pgstat progress */`
`3317`	`3317`
`3318`	`3318`	`typedef enum ReindexObjectType`
`3319`	`3319`	`{`