Enlarge find_other_exec's meager fgets buffer

alvherre · alvherre · commit cea5f9aa1244 · 2018-04-19T10:45:15.000-03:00
The buffer was 100 bytes long, which is barely sufficient when the version string gets longer (such as by configure --with-extra-version). Set it to MAXPGPATH. Author: Nikhil Sontakke Discussion: https://postgr.es/m/CAMGcDxfLfpYU_Jru++L6ARPCOyxr0W+2O3Q54TDi5XdYeU36ow@mail.gmail.com
diff --git a/src/common/exec.c b/src/common/exec.c
@@ -308,7 +308,7 @@ find_other_exec(const char *argv0, const char *target,
 				const char *versionstr, char *retpath)
 {
 	char		cmd[MAXPGPATH];
-	char		line[100];
+	char		line[MAXPGPATH];
 
 	if (find_my_exec(argv0, retpath) < 0)
 		return -1;

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ find_other_exec(const char argv0, const char target,`
`308`	`308`	`const char versionstr, char retpath)`
`309`	`309`	`{`
`310`	`310`	`char cmd[MAXPGPATH];`
`311`		`- char line[100];`
	`311`	`+ char line[MAXPGPATH];`
`312`	`312`
`313`	`313`	`if (find_my_exec(argv0, retpath) < 0)`
`314`	`314`	`return -1;`