Make lwlocknames.h generated file less ugly

alvherre · alvherre · commit da0f0582e81e · 2025-03-13T17:38:21.000+01:00
We can make the output look a bit better by aligning each lock's definition, so add some padding space to achieve that. This change makes no practical difference, but casual onlookers will be less distracted by (lack of) whitespace. Author: Gurjeet Singh <gurjeet@singh.im> Discussion: https://postgr.es/m/CABwTF4VxfwDtRV-H22_XK4XeDogaV-Vaobu+af5U=8ZAZn9ZZQ@mail.gmail.com
diff --git a/src/backend/storage/lmgr/generate-lwlocknames.pl b/src/backend/storage/lmgr/generate-lwlocknames.pl
@@ -108,7 +108,8 @@
 	$continue = ",\n";
 
 	# Add a "Lock" suffix to each lock name, as the C code depends on that
-	print $h "#define ${lockname}Lock (&MainLWLockArray[$lockidx].lock)\n";
+	printf $h "#define %-32s (&MainLWLockArray[$lockidx].lock)\n",
+	  $lockname . "Lock";
 }
 
 die

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,8 @@`
`108`	`108`	`$continue = ",\n";`
`109`	`109`
`110`	`110`	`# Add a "Lock" suffix to each lock name, as the C code depends on that`
`111`		`- print $h "#define ${lockname}Lock (&MainLWLockArray[$lockidx].lock)\n";`
	`111`	`+ printf $h "#define %-32s (&MainLWLockArray[$lockidx].lock)\n",`
	`112`	`+ $lockname . "Lock";`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`die`