Fix off-by-one error in pg_waldump, introduced in 5c279a6.

jeff-davis · jeff-davis · commit dad97e0502b4 · 2022-04-07T09:14:49.000-07:00
Per report by Bharath Rupireddy. Discussion: https://postgr.es/m/CALj2ACX+PWDK2MYjdu8CB1ot7OUSo6kd5-fkkEgduEsTSZjAEw@mail.gmail.com
diff --git a/src/bin/pg_waldump/pg_waldump.c b/src/bin/pg_waldump/pg_waldump.c
@@ -720,7 +720,7 @@ XLogDumpDisplayStats(XLogDumpConfig *config, XLogDumpStats *stats)
 	 * calculate column totals.
 	 */
 
-	for (ri = 0; ri < RM_MAX_ID; ri++)
+	for (ri = 0; ri <= RM_MAX_ID; ri++)
 	{
 		total_count += stats->rmgr_stats[ri].count;
 		total_rec_len += stats->rmgr_stats[ri].rec_len;

Original file line number	Diff line number	Diff line change
`@@ -720,7 +720,7 @@ XLogDumpDisplayStats(XLogDumpConfig config, XLogDumpStats stats)`
`720`	`720`	`* calculate column totals.`
`721`	`721`	`*/`
`722`	`722`
`723`		`- for (ri = 0; ri < RM_MAX_ID; ri++)`
	`723`	`+ for (ri = 0; ri <= RM_MAX_ID; ri++)`
`724`	`724`	`{`
`725`	`725`	`total_count += stats->rmgr_stats[ri].count;`
`726`	`726`	`total_rec_len += stats->rmgr_stats[ri].rec_len;`