Wake up interested backends when a checkpoint fails.

macdice · macdice · commit de2b38419c40 · 2019-04-06T09:31:48.000+13:00
Commit c6c9474 switched to condition variables instead of sleep loops to notify backends of checkpoint start and stop, but forgot to broadcast in case of checkpoint failure. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKGJKbCd%2B_K%2BSEBsbHxVT60SG0ivWHHAdvL0bLTUt2xpA2w%40mail.gmail.com
diff --git a/src/backend/postmaster/checkpointer.c b/src/backend/postmaster/checkpointer.c
@@ -279,6 +279,8 @@ CheckpointerMain(void)
 			CheckpointerShmem->ckpt_done = CheckpointerShmem->ckpt_started;
 			SpinLockRelease(&CheckpointerShmem->ckpt_lck);
 
+			ConditionVariableBroadcast(&CheckpointerShmem->done_cv);
+
 			ckpt_active = false;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,8 @@ CheckpointerMain(void)`
`279`	`279`	`CheckpointerShmem->ckpt_done = CheckpointerShmem->ckpt_started;`
`280`	`280`	`SpinLockRelease(&CheckpointerShmem->ckpt_lck);`
`281`	`281`
	`282`	`+ ConditionVariableBroadcast(&CheckpointerShmem->done_cv);`
	`283`	`+`
`282`	`284`	`ckpt_active = false;`
`283`	`285`	`}`
`284`	`286`