Suppress compiler warning in non-cassert builds.

tglsfdc · tglsfdc · commit e942af7b8261 · 2020-08-26T17:08:11.000-04:00
Oversight in 808e13b, reported by Bruce Momjian. Discussion: https://postgr.es/m/20200826160251.GB21909@momjian.us
diff --git a/src/backend/storage/file/sharedfileset.c b/src/backend/storage/file/sharedfileset.c
@@ -285,7 +285,6 @@ SharedFileSetDeleteOnProcExit(int status, Datum arg)
 void
 SharedFileSetUnregister(SharedFileSet *input_fileset)
 {
-	bool		found = false;
 	ListCell   *l;
 
 	/*
@@ -303,12 +302,12 @@ SharedFileSetUnregister(SharedFileSet *input_fileset)
 		if (input_fileset == fileset)
 		{
 			filesetlist = list_delete_cell(filesetlist, l);
-			found = true;
-			break;
+			return;
 		}
 	}
 
-	Assert(found);
+	/* Should have found a match */
+	Assert(false);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,6 @@ SharedFileSetDeleteOnProcExit(int status, Datum arg)`
`285`	`285`	`void`
`286`	`286`	`SharedFileSetUnregister(SharedFileSet *input_fileset)`
`287`	`287`	`{`
`288`		`- bool found = false;`
`289`	`288`	`ListCell *l;`
`290`	`289`
`291`	`290`	`/*`
`@@ -303,12 +302,12 @@ SharedFileSetUnregister(SharedFileSet *input_fileset)`
`303`	`302`	`if (input_fileset == fileset)`
`304`	`303`	`{`
`305`	`304`	`filesetlist = list_delete_cell(filesetlist, l);`
`306`		`- found = true;`
`307`		`- break;`
	`305`	`+ return;`
`308`	`306`	`}`
`309`	`307`	`}`
`310`	`308`
`311`		`- Assert(found);`
	`309`	`+ /* Should have found a match */`
	`310`	`+ Assert(false);`
`312`	`311`	`}`
`313`	`312`
`314`	`313`	`/*`