Skip to content

Commit ec1a405

Browse files
david-rowleydavid-rowley
committed
Revert "Temporarily install debugging in partition_prune test"
1db6897 added debugging output to the partition_prune regression test to help us figure out why buildfarm member Parula was occasionally failing. We've not seen any failures in around 4 weeks and the best guess as to what the problem was is a compiler bug. Since there are no recent failures, there's now no need to keep this debugging code, so revert it. Discussion: https://postgr.es/m/CAApHDvqyLF881EvDtXT=ossa0i4ioJBtW2c0Wbouzt5d3HDb5Q@mail.gmail.com
1 parent 6961753 commit ec1a405

File tree

2 files changed

+0
-76
lines changed

2 files changed

+0
-76
lines changed

‎src/test/regress/expected/partition_prune.out‎

Lines changed: 0 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -2449,37 +2449,6 @@ create index ab_a3_b3_a_idx on ab_a3_b3 (a);
24492449
set enable_hashjoin = 0;
24502450
set enable_mergejoin = 0;
24512451
set enable_memoize = 0;
2452-
-- Temporarily install some debugging to investigate plan instability.
2453-
select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count
2454-
from pg_class c
2455-
left join pg_stat_all_tables s on c.oid = s.relid
2456-
left join pg_index i on c.oid = i.indexrelid
2457-
where c.relname like 'ab\_%' order by c.relname;
2458-
relname | relpages | reltuples | indisvalid | autovacuum_count | autoanalyze_count
2459-
----------------+----------+-----------+------------+------------------+-------------------
2460-
ab_a1 | 0 | -1 | | 0 | 0
2461-
ab_a1_b1 | 0 | -1 | | 0 | 0
2462-
ab_a1_b1_a_idx | 1 | 0 | t | |
2463-
ab_a1_b2 | 0 | -1 | | 0 | 0
2464-
ab_a1_b2_a_idx | 1 | 0 | t | |
2465-
ab_a1_b3 | 0 | -1 | | 0 | 0
2466-
ab_a1_b3_a_idx | 1 | 0 | t | |
2467-
ab_a2 | 0 | -1 | | 0 | 0
2468-
ab_a2_b1 | 0 | -1 | | 0 | 0
2469-
ab_a2_b1_a_idx | 1 | 0 | t | |
2470-
ab_a2_b2 | 0 | -1 | | 0 | 0
2471-
ab_a2_b2_a_idx | 1 | 0 | t | |
2472-
ab_a2_b3 | 0 | -1 | | 0 | 0
2473-
ab_a2_b3_a_idx | 1 | 0 | t | |
2474-
ab_a3 | 0 | -1 | | 0 | 0
2475-
ab_a3_b1 | 0 | -1 | | 0 | 0
2476-
ab_a3_b1_a_idx | 1 | 0 | t | |
2477-
ab_a3_b2 | 0 | -1 | | 0 | 0
2478-
ab_a3_b2_a_idx | 1 | 0 | t | |
2479-
ab_a3_b3 | 0 | -1 | | 0 | 0
2480-
ab_a3_b3_a_idx | 1 | 0 | t | |
2481-
(21 rows)
2482-
24832452
select explain_parallel_append('select avg(ab.a) from ab inner join lprt_a a on ab.a = a.a where a.a in(0, 0, 1)');
24842453
explain_parallel_append
24852454
--------------------------------------------------------------------------------------------------------
@@ -2855,37 +2824,6 @@ deallocate ab_q3;
28552824
deallocate ab_q4;
28562825
deallocate ab_q5;
28572826
deallocate ab_q6;
2858-
-- Temporarily install some debugging to investigate plan instability.
2859-
select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count
2860-
from pg_class c
2861-
left join pg_stat_all_tables s on c.oid = s.relid
2862-
left join pg_index i on c.oid = i.indexrelid
2863-
where c.relname like 'ab\_%' order by c.relname;
2864-
relname | relpages | reltuples | indisvalid | autovacuum_count | autoanalyze_count
2865-
----------------+----------+-----------+------------+------------------+-------------------
2866-
ab_a1 | 0 | -1 | | 0 | 0
2867-
ab_a1_b1 | 0 | -1 | | 0 | 0
2868-
ab_a1_b1_a_idx | 1 | 0 | t | |
2869-
ab_a1_b2 | 0 | -1 | | 0 | 0
2870-
ab_a1_b2_a_idx | 1 | 0 | t | |
2871-
ab_a1_b3 | 0 | -1 | | 0 | 0
2872-
ab_a1_b3_a_idx | 1 | 0 | t | |
2873-
ab_a2 | 0 | -1 | | 0 | 0
2874-
ab_a2_b1 | 0 | -1 | | 0 | 0
2875-
ab_a2_b1_a_idx | 1 | 0 | t | |
2876-
ab_a2_b2 | 0 | -1 | | 0 | 0
2877-
ab_a2_b2_a_idx | 1 | 0 | t | |
2878-
ab_a2_b3 | 0 | -1 | | 0 | 0
2879-
ab_a2_b3_a_idx | 1 | 0 | t | |
2880-
ab_a3 | 0 | -1 | | 0 | 0
2881-
ab_a3_b1 | 0 | -1 | | 0 | 0
2882-
ab_a3_b1_a_idx | 1 | 0 | t | |
2883-
ab_a3_b2 | 0 | -1 | | 0 | 0
2884-
ab_a3_b2_a_idx | 1 | 0 | t | |
2885-
ab_a3_b3 | 0 | -1 | | 0 | 0
2886-
ab_a3_b3_a_idx | 1 | 0 | t | |
2887-
(21 rows)
2888-
28892827
-- UPDATE on a partition subtree has been seen to have problems.
28902828
insert into ab values (1,2);
28912829
explain (analyze, costs off, summary off, timing off)

‎src/test/regress/sql/partition_prune.sql‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -607,13 +607,6 @@ set enable_hashjoin = 0;
607607
set enable_mergejoin = 0;
608608
set enable_memoize = 0;
609609

610-
-- Temporarily install some debugging to investigate plan instability.
611-
select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count
612-
from pg_class c
613-
left join pg_stat_all_tables s on c.oid = s.relid
614-
left join pg_index i on c.oid = i.indexrelid
615-
where c.relname like 'ab\_%' order by c.relname;
616-
617610
select explain_parallel_append('select avg(ab.a) from ab inner join lprt_a a on ab.a = a.a where a.a in(0, 0, 1)');
618611

619612
-- Ensure the same partitions are pruned when we make the nested loop
@@ -681,13 +674,6 @@ deallocate ab_q4;
681674
deallocate ab_q5;
682675
deallocate ab_q6;
683676

684-
-- Temporarily install some debugging to investigate plan instability.
685-
select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count
686-
from pg_class c
687-
left join pg_stat_all_tables s on c.oid = s.relid
688-
left join pg_index i on c.oid = i.indexrelid
689-
where c.relname like 'ab\_%' order by c.relname;
690-
691677
-- UPDATE on a partition subtree has been seen to have problems.
692678
insert into ab values (1,2);
693679
explain (analyze, costs off, summary off, timing off)

0 commit comments

Comments
 (0)