pg_amcheck: Fix inconsistency in memory freeing

michaelpq · michaelpq · commit f903d4da9276 · 2025-02-27T14:05:55.000+09:00
The function in charge of freeing the memory from a result created by PQescapeIdentifier() has to be PQfreemem(), to ensure that both allocation and free come from libpq, but one spot in pg_amcheck was missing that. Oversight in b859d94. Author: Ranier Vilela <ranier.vf@gmail.com> Reviewed-by: vignesh C <vignesh21@gmail.com> Discussion: https://postgr.es/m/CAEudQArD_nKSnYCNUZiPPsJ2tNXgRmLbXGSOrH1vpOF_XtP0Vg@mail.gmail.com Discussion: https://postgr.es/m/CAEudQArbTWVSbxq608GRmXJjnNSQ0B6R7CSffNnj2hPWMUsRNg@mail.gmail.com Backpatch-through: 14
diff --git a/src/bin/pg_amcheck/pg_amcheck.c b/src/bin/pg_amcheck/pg_amcheck.c
@@ -559,7 +559,7 @@ main(int argc, char *argv[])
 
 			executeCommand(conn, install_sql, opts.echo);
 			pfree(install_sql);
-			pfree(schema);
+			PQfreemem(schema);
 		}
 
 		/*

Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,7 @@ main(int argc, char *argv[])`
`559`	`559`
`560`	`560`	`executeCommand(conn, install_sql, opts.echo);`
`561`	`561`	`pfree(install_sql);`
`562`		`- pfree(schema);`
	`562`	`+ PQfreemem(schema);`
`563`	`563`	`}`
`564`	`564`
`565`	`565`	`/*`