Makeover for Unixware 7.1.1

* Makefile: Add more standard targets.  Improve shell redirection in GNU
make detection.
* src/backend/access/transam/rmgr.c: Fix incorrect(?) C.
* src/backend/libpq/pqcomm.c (StreamConnection): Work around accept() bug.
* src/include/port/unixware.h: ...with help from here.
* src/backend/nodes/print.c (plannode_type): Remove some "break"s after
"return"s.
* src/backend/tcop/dest.c (DestToFunction): ditto.
* src/backend/nodes/readfuncs.c: Add proper prototypes.
* src/backend/utils/adt/numutils.c (pg_atoi): Cope specially with strtol()
setting EINVAL. This saves us from creating an extra set of regression test
output for the affected systems.
* src/include/storage/s_lock.h (tas): Correct prototype.
* src/interfaces/libpq/fe-connect.c (parseServiceInfo): Don't use variable
as dimension in array definition.
* src/makefiles/Makefile.unixware: Add support for GCC.
* src/template/unixware: same here
* src/test/regress/expected/abstime-solaris-1947.out: Adjust whitespace.
* src/test/regress/expected/horology-solaris-1947.out: Part of this file
was evidently missing.
* src/test/regress/pg_regress.sh: Fix shell.  mkdir -p returns non-zero if
the directory exists.
* src/test/regress/resultmap: Add entries for Unixware.

Author: petere

Makefile

@@ -11,7 +11,7 @@
 # GNUmakefile won't exist yet, so we catch that case as well.
 
 
-all install clean dep depend distclean maintainer-clean:
+all check install installdirs installcheck uninstall dep depend clean distclean maintainer-clean:
 	@if ! [ -f GNUmakefile ] ; then \
 	   echo "You need to run the \`configure' program first. See the file"; \
 	   echo "\`INSTALL' for installation instructions." ; \
@@ -20,7 +20,7 @@ all install clean dep depend distclean maintainer-clean:
 	@IFS=':' ; \
 	 for dir in $$PATH; do \
 	   for prog in gmake gnumake make; do \
-	     if [ -f $$dir/$$prog ] && ( $$dir/$$prog --version | grep GNU >/dev/null 2>&1 ) ; then \
+	     if [ -f $$dir/$$prog ] && ( $$dir/$$prog --version 2>/dev/null | grep GNU >/dev/null 2>&1 ) ; then \
 	       GMAKE=$$dir/$$prog; \
 	       break 2; \
 	     fi; \

src/backend/access/transam/rmgr.c

@@ -52,8 +52,12 @@ RmgrData   RmgrTable[] = {
 {"Gist", gist_redo, gist_undo, gist_desc}
 };
 
-#else
+#else /* not XLOG */
 
-RmgrData   RmgrTable[] = {};
+/*
+ * This is a dummy, but don't write RmgrTable[] = {} here,
+ * that's not accepted by some compilers. -- petere
+ */
+RmgrData   RmgrTable[1];
 
-#endif
+#endif /* not XLOG */

src/backend/libpq/pqcomm.c

@@ -29,7 +29,7 @@
  * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Id: pqcomm.c,v 1.106 2000/10/14 23:56:58 momjian Exp $
+ *	$Id: pqcomm.c,v 1.107 2000/10/22 22:14:54 petere Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -332,6 +332,15 @@ StreamConnection(int server_fd, Port *port)
 		return STATUS_ERROR;
 	}
 
+#ifdef PG_ON_UNIXWARE
+	/*
+	 * Only UnixWare 7+ are known to have this bug, but it shouldn't
+	 * hurt it catch if for all of them.
+	 */
+	if (port->raddr.sa.sa_family == 0)
+		port->raddr.sa.sa_family = AF_UNIX;
+#endif
+
 	/* fill in the server (local) address */
 	addrlen = sizeof(port->laddr);
 	if (getsockname(port->sock, (struct sockaddr *) & port->laddr,

src/backend/nodes/print.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/nodes/print.c,v 1.43 2000/10/05 19:11:27 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/nodes/print.c,v 1.44 2000/10/22 22:14:54 petere Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -292,64 +292,44 @@ plannode_type(Plan *p)
 	{
 		case T_Plan:
 			return "PLAN";
-			break;
 		case T_Result:
 			return "RESULT";
-			break;
 		case T_Append:
 			return "APPEND";
-			break;
 		case T_Scan:
 			return "SCAN";
-			break;
 		case T_SeqScan:
 			return "SEQSCAN";
-			break;
 		case T_IndexScan:
 			return "INDEXSCAN";
-			break;
 		case T_TidScan:
 			return "TIDSCAN";
-			break;
 		case T_SubqueryScan:
 			return "SUBQUERYSCAN";
-			break;
 		case T_Join:
 			return "JOIN";
-			break;
 		case T_NestLoop:
 			return "NESTLOOP";
-			break;
 		case T_MergeJoin:
 			return "MERGEJOIN";
-			break;
 		case T_HashJoin:
 			return "HASHJOIN";
-			break;
 		case T_Material:
 			return "MATERIAL";
-			break;
 		case T_Sort:
 			return "SORT";
-			break;
 		case T_Agg:
 			return "AGG";
-			break;
 		case T_Unique:
 			return "UNIQUE";
-			break;
 		case T_SetOp:
 			return "SETOP";
-			break;
 		case T_Hash:
 			return "HASH";
-			break;
 		case T_Group:
 			return "GROUP";
-			break;
 		default:
 			return "UNKNOWN";
-			break;
 	}
 }