Reduce variable scope and possibly useless palloc

david-rowley · david-rowley · commit fcbd1bb6613f · 2024-10-30T01:38:42.000+13:00
Move the CreateStmt down to the branch that it's used in, thus preventing the makeNode() call in cases where the CreateStmt isn't used. Author: Ranier Vilela <ranier.vf@gmail.com> Discussion: https://postgr.es/m/CAEudQAq=06YPWPhS+yyTbCwv5JLKRz8rm3dWx6JR5Uj_d_fQDA@mail.gmail.com
diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c
@@ -47,7 +47,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 {
 	Oid			viewOid;
 	LOCKMODE	lockmode;
-	CreateStmt *createStmt = makeNode(CreateStmt);
 	List	   *attrList;
 	ListCell   *t;
 
@@ -223,6 +222,7 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 	}
 	else
 	{
+		CreateStmt *createStmt = makeNode(CreateStmt);
 		ObjectAddress address;
 
 		/*

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ DefineVirtualRelation(RangeVar relation, List tlist, bool replace,`
`47`	`47`	`{`
`48`	`48`	`Oid viewOid;`
`49`	`49`	`LOCKMODE lockmode;`
`50`		`- CreateStmt *createStmt = makeNode(CreateStmt);`
`51`	`50`	`List *attrList;`
`52`	`51`	`ListCell *t;`
`53`	`52`
`@@ -223,6 +222,7 @@ DefineVirtualRelation(RangeVar relation, List tlist, bool replace,`
`223`	`222`	`}`
`224`	`223`	`else`
`225`	`224`	`{`
	`225`	`+ CreateStmt *createStmt = makeNode(CreateStmt);`
`226`	`226`	`ObjectAddress address;`
`227`	`227`
`228`	`228`	`/*`