Minor cleanup for win32stat.c.

tglsfdc · tglsfdc · commit fcd11329db5b · 2020-10-12T11:13:02.000-04:00
Use GetLastError(), rather than assuming that CreateFile() failure must map to ENOENT. Noted by Michael Paquier. Discussion: https://postgr.es/m/CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com
diff --git a/src/port/win32stat.c b/src/port/win32stat.c
@@ -204,8 +204,10 @@ _pgstat64(const char *name, struct stat *buf)
 					   NULL);
 	if (hFile == INVALID_HANDLE_VALUE)
 	{
+		DWORD		err = GetLastError();
+
 		CloseHandle(hFile);
-		errno = ENOENT;
+		_dosmaperr(err);
 		return -1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -204,8 +204,10 @@ _pgstat64(const char name, struct stat buf)`
`204`	`204`	`NULL);`
`205`	`205`	`if (hFile == INVALID_HANDLE_VALUE)`
`206`	`206`	`{`
	`207`	`+ DWORD err = GetLastError();`
	`208`	`+`
`207`	`209`	`CloseHandle(hFile);`
`208`		`- errno = ENOENT;`
	`210`	`+ _dosmaperr(err);`
`209`	`211`	`return -1;`
`210`	`212`	`}`
`211`	`213`