Fix misleading comment in paraminfo_get_equal_hashops

david-rowley · david-rowley · commit fdd79d8992d6 · 2023-08-07T18:16:46.000+12:00
The comment mistakenly claimed the code was checking PlaceHolderVars for volatile functions when the code was actually checking lateral vars. Update the comment to reflect the reality of the code. Author: Richard Guo Discussion: https://postgr.es/m/CAMbWs48HZGZOV85g0fx8z1qDx6NNKHexJPT2FCnKnZhxBWkd-A@mail.gmail.com
diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c
@@ -529,7 +529,7 @@ paraminfo_get_equal_hashops(PlannerInfo *root, ParamPathInfo *param_info,
 		Node	   *expr = (Node *) lfirst(lc);
 		TypeCacheEntry *typentry;
 
-		/* Reject if there are any volatile functions in PHVs */
+		/* Reject if there are any volatile functions in lateral vars */
 		if (contain_volatile_functions(expr))
 		{
 			list_free(*operators);

Original file line number	Diff line number	Diff line change
`@@ -529,7 +529,7 @@ paraminfo_get_equal_hashops(PlannerInfo root, ParamPathInfo param_info,`
`529`	`529`	`Node expr = (Node ) lfirst(lc);`
`530`	`530`	`TypeCacheEntry *typentry;`
`531`	`531`
`532`		`- /* Reject if there are any volatile functions in PHVs */`
	`532`	`+ /* Reject if there are any volatile functions in lateral vars */`
`533`	`533`	`if (contain_volatile_functions(expr))`
`534`	`534`	`{`
`535`	`535`	`list_free(*operators);`