Fix compiler warning on Windows.

tglsfdc · tglsfdc · commit fe4ecd08d81c · 2018-05-02T00:25:35.000-04:00
Commit 41c912c caused MSVC to complain that not all control paths return a value. Thomas Munro Discussion: https://postgr.es/m/CAEepm%3D3%3DTDYEXUEcHpEx%2BTwc31wo7PA0oBAiNt6sWmq93MW02A%40mail.gmail.com
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -1980,7 +1980,8 @@ evalStandardFunc(TState *thread, CState *st,
 					}
 				}
 
-				break;			/* NOTREACHED */
+				Assert(0);
+				return false;	/* NOTREACHED */
 			}
 
 			/* integer bitwise operators */

Original file line number	Diff line number	Diff line change
`@@ -1980,7 +1980,8 @@ evalStandardFunc(TState thread, CState st,`
`1980`	`1980`	`}`
`1981`	`1981`	`}`
`1982`	`1982`
`1983`		`- break; /* NOTREACHED */`
	`1983`	`+ Assert(0);`
	`1984`	`+ return false; /* NOTREACHED */`
`1984`	`1985`	`}`
`1985`	`1986`
`1986`	`1987`	`/* integer bitwise operators */`