Fix silly mistake in expand_indexqual_rowcompare --- in converting a forboth()

tglsfdc · tglsfdc · commit 09bb6f6ed026 · 2008-02-07T17:53:53.000Z
into an iteration over three parallel lists, I had accidentally put the lnext
steps outside the loop.  Sigh.  Per bug #3938.
diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.226 2008/01/01 19:45:50 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.227 2008/02/07 17:53:53 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2619,9 +2619,9 @@ expand_indexqual_rowcompare(RestrictInfo *rinfo,
 						 op_strategy, lefttype, righttype, opfam);
 			}
 			new_ops = lappend_oid(new_ops, expr_op);
+			lefttypes_cell = lnext(lefttypes_cell);
+			righttypes_cell = lnext(righttypes_cell);
 		}
-		lefttypes_cell = lnext(lefttypes_cell);
-		righttypes_cell = lnext(righttypes_cell);
 	}
 
 	/* If we have more than one matching col, create a subset rowcompare */

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.226 2008/01/01 19:45:50 momjian Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.227 2008/02/07 17:53:53 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -2619,9 +2619,9 @@ expand_indexqual_rowcompare(RestrictInfo *rinfo,`
`2619`	`2619`	`op_strategy, lefttype, righttype, opfam);`
`2620`	`2620`	`}`
`2621`	`2621`	`new_ops = lappend_oid(new_ops, expr_op);`
	`2622`	`+ lefttypes_cell = lnext(lefttypes_cell);`
	`2623`	`+ righttypes_cell = lnext(righttypes_cell);`
`2622`	`2624`	`}`
`2623`		`- lefttypes_cell = lnext(lefttypes_cell);`
`2624`		`- righttypes_cell = lnext(righttypes_cell);`
`2625`	`2625`	`}`
`2626`	`2626`
`2627`	`2627`	`/* If we have more than one matching col, create a subset rowcompare */`