Fix range check for effective_io_concurrency

alvherre · alvherre · commit 0c7cd45b6d70 · 2016-05-24T14:55:34.000-04:00
Commit 1aba62e moved the range check of that option form guc.c into bufmgr.c, but introduced a bug by changing a >= 0.0 to > 0.0, which made the value 0 no longer accepted. Put it back. Reported by Jeff Janes, diagnosed by Tom Lane
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -514,7 +514,7 @@ ComputeIoConcurrency(int io_concurrency, double *target)
 	*target = new_prefetch_pages;
 
 	/* This range check shouldn't fail, but let's be paranoid */
-	return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);
+	return (new_prefetch_pages >= 0.0 && new_prefetch_pages < (double) INT_MAX);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ ComputeIoConcurrency(int io_concurrency, double *target)`
`514`	`514`	`*target = new_prefetch_pages;`
`515`	`515`
`516`	`516`	`/* This range check shouldn't fail, but let's be paranoid */`
`517`		`- return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);`
	`517`	`+ return (new_prefetch_pages >= 0.0 && new_prefetch_pages < (double) INT_MAX);`
`518`	`518`	`}`
`519`	`519`
`520`	`520`	`/*`