Silence warning about uninitialized 'ret' variable on some compilers.

hlinnaka · hlinnaka · commit 493490cbcb19 · 2017-06-09T21:50:35.000+03:00
If the compiler doesn't notice that the switch-statement handles all possible values of the enum, it might complain that 'ret' is being used without initialization. Jeff Janes reported that on gcc 4.4.7. Discussion: https://www.postgresql.org/message-id/CAMkU=1x31RvP+cpooFbmc8K8nt-gNO8woGFhXcgQYYZ5ozYpFA@mail.gmail.com
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -1668,6 +1668,7 @@ connectDBStart(PGconn *conn)
 		snprintf(portstr, sizeof(portstr), "%d", thisport);
 
 		/* Use pg_getaddrinfo_all() to resolve the address */
+		ret = 1;
 		switch (ch->type)
 		{
 			case CHT_HOST_NAME:

Original file line number	Diff line number	Diff line change
`@@ -1668,6 +1668,7 @@ connectDBStart(PGconn *conn)`
`1668`	`1668`	`snprintf(portstr, sizeof(portstr), "%d", thisport);`
`1669`	`1669`
`1670`	`1670`	`/* Use pg_getaddrinfo_all() to resolve the address */`
	`1671`	`+ ret = 1;`
`1671`	`1672`	`switch (ch->type)`
`1672`	`1673`	`{`
`1673`	`1674`	`case CHT_HOST_NAME:`