Print a MergeJoin's mergeNullsFirst array as bool, not int.

robertmhaas · robertmhaas · commit 4fe6f72bda7b · 2015-09-23T10:53:29.000-04:00
It's declared as being an array of bool, but it's printed
differently from the way bool and arrays of bool are handled
elsewhere.

Patch by Amit Kapila.  Anomaly noted independently by Amit Kapila
and KaiGai Kohei.
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
@@ -649,7 +649,7 @@ _outMergeJoin(StringInfo str, const MergeJoin *node)
 
 	appendStringInfoString(str, " :mergeNullsFirst");
 	for (i = 0; i < numCols; i++)
-		appendStringInfo(str, " %d", (int) node->mergeNullsFirst[i]);
+		appendStringInfo(str, " %s", booltostr(node->mergeNullsFirst[i]));
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,7 @@ _outMergeJoin(StringInfo str, const MergeJoin *node)`
`649`	`649`
`650`	`650`	`appendStringInfoString(str, " :mergeNullsFirst");`
`651`	`651`	`for (i = 0; i < numCols; i++)`
`652`		`- appendStringInfo(str, " %d", (int) node->mergeNullsFirst[i]);`
	`652`	`+ appendStringInfo(str, " %s", booltostr(node->mergeNullsFirst[i]));`
`653`	`653`	`}`
`654`	`654`
`655`	`655`	`static void`