pgbench: Increase maximum size of log filename from 64 to MAXPGPATH.

robertmhaas · robertmhaas · commit 56eba9b8a112 · 2016-11-15T09:11:51.000-05:00
Commit 41124a9 allowed the transaction log file prefix to be changed but left in place the existing 64-character limit on the total length of a log file name. It's possible that could be inconvenient for somebody, so increase the limit to MAXPGPATH, which ought to be enough for anybody. Per a suggestion from Tom Lane.
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -4401,7 +4401,7 @@ threadRun(void *arg)
 	/* open log file if requested */
 	if (use_log)
 	{
-		char		logpath[64];
+		char		logpath[MAXPGPATH];
 		char		*prefix = logfile_prefix ? logfile_prefix : "pgbench_log";
 
 		if (thread->tid == 0)

Original file line number	Diff line number	Diff line change
`@@ -4401,7 +4401,7 @@ threadRun(void *arg)`
`4401`	`4401`	`/* open log file if requested */`
`4402`	`4402`	`if (use_log)`
`4403`	`4403`	`{`
`4404`		`- char logpath[64];`
	`4404`	`+ char logpath[MAXPGPATH];`
`4405`	`4405`	`char *prefix = logfile_prefix ? logfile_prefix : "pgbench_log";`
`4406`	`4406`
`4407`	`4407`	`if (thread->tid == 0)`