Skip to content

Commit 5ef037c

Browse files
michaelpqmichaelpq
committed
List wait events in alphabetical order
This changes the documentation, and the related structures so as everything is consistent. Some wait events were not listed alphabetically since their introduction, others have been added rather randomly. Keeping all those entries in order helps in maintenance, and helps the user looking at the documentation. Author: Michael Paquier, Kuntal Ghosh Discussion: https://postgr.es/m/20181024002539.GI1658@paquier.xyz Backpatch-through: 10, only for the documentation part to avoid an ABI breakage.
1 parent 5d7c703 commit 5ef037c

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

‎doc/src/sgml/monitoring.sgml‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,14 +1193,14 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
11931193
<entry><literal>CheckpointerMain</literal></entry>
11941194
<entry>Waiting in main loop of checkpointer process.</entry>
11951195
</row>
1196-
<row>
1197-
<entry><literal>LogicalLauncherMain</literal></entry>
1198-
<entry>Waiting in main loop of logical launcher process.</entry>
1199-
</row>
12001196
<row>
12011197
<entry><literal>LogicalApplyMain</literal></entry>
12021198
<entry>Waiting in main loop of logical apply process.</entry>
12031199
</row>
1200+
<row>
1201+
<entry><literal>LogicalLauncherMain</literal></entry>
1202+
<entry>Waiting in main loop of logical launcher process.</entry>
1203+
</row>
12041204
<row>
12051205
<entry><literal>PgStatMain</literal></entry>
12061206
<entry>Waiting in main loop of the statistics collector process.</entry>
@@ -1280,6 +1280,10 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
12801280
<entry><literal>BtreePage</literal></entry>
12811281
<entry>Waiting for the page number needed to continue a parallel B-tree scan to become available.</entry>
12821282
</row>
1283+
<row>
1284+
<entry><literal>ClogGroupUpdate</literal></entry>
1285+
<entry>Waiting for group leader to update transaction status at transaction end.</entry>
1286+
</row>
12831287
<row>
12841288
<entry><literal>ExecuteGather</literal></entry>
12851289
<entry>Waiting for activity from child process when executing <literal>Gather</literal> node.</entry>
@@ -1368,10 +1372,6 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
13681372
<entry><literal>MessageQueueSend</literal></entry>
13691373
<entry>Waiting to send bytes to a shared message queue.</entry>
13701374
</row>
1371-
<row>
1372-
<entry><literal>ParallelFinish</literal></entry>
1373-
<entry>Waiting for parallel workers to finish computing.</entry>
1374-
</row>
13751375
<row>
13761376
<entry><literal>ParallelBitmapScan</literal></entry>
13771377
<entry>Waiting for parallel bitmap scan to become initialized.</entry>
@@ -1381,12 +1381,12 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
13811381
<entry>Waiting for parallel <command>CREATE INDEX</command> workers to finish heap scan.</entry>
13821382
</row>
13831383
<row>
1384-
<entry><literal>ProcArrayGroupUpdate</literal></entry>
1385-
<entry>Waiting for group leader to clear transaction id at transaction end.</entry>
1384+
<entry><literal>ParallelFinish</literal></entry>
1385+
<entry>Waiting for parallel workers to finish computing.</entry>
13861386
</row>
13871387
<row>
1388-
<entry><literal>ClogGroupUpdate</literal></entry>
1389-
<entry>Waiting for group leader to update transaction status at transaction end.</entry>
1388+
<entry><literal>ProcArrayGroupUpdate</literal></entry>
1389+
<entry>Waiting for group leader to clear transaction id at transaction end.</entry>
13901390
</row>
13911391
<row>
13921392
<entry><literal>ReplicationOriginDrop</literal></entry>

‎src/backend/postmaster/pgstat.c‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3484,12 +3484,12 @@ pgstat_get_wait_activity(WaitEventActivity w)
34843484
case WAIT_EVENT_CHECKPOINTER_MAIN:
34853485
event_name = "CheckpointerMain";
34863486
break;
3487-
case WAIT_EVENT_LOGICAL_LAUNCHER_MAIN:
3488-
event_name = "LogicalLauncherMain";
3489-
break;
34903487
case WAIT_EVENT_LOGICAL_APPLY_MAIN:
34913488
event_name = "LogicalApplyMain";
34923489
break;
3490+
case WAIT_EVENT_LOGICAL_LAUNCHER_MAIN:
3491+
event_name = "LogicalLauncherMain";
3492+
break;
34933493
case WAIT_EVENT_PGSTAT_MAIN:
34943494
event_name = "PgStatMain";
34953495
break;
@@ -3582,6 +3582,9 @@ pgstat_get_wait_ipc(WaitEventIPC w)
35823582
case WAIT_EVENT_BTREE_PAGE:
35833583
event_name = "BtreePage";
35843584
break;
3585+
case WAIT_EVENT_CLOG_GROUP_UPDATE:
3586+
event_name = "ClogGroupUpdate";
3587+
break;
35853588
case WAIT_EVENT_EXECUTE_GATHER:
35863589
event_name = "ExecuteGather";
35873590
break;
@@ -3648,21 +3651,18 @@ pgstat_get_wait_ipc(WaitEventIPC w)
36483651
case WAIT_EVENT_MQ_SEND:
36493652
event_name = "MessageQueueSend";
36503653
break;
3651-
case WAIT_EVENT_PARALLEL_FINISH:
3652-
event_name = "ParallelFinish";
3653-
break;
36543654
case WAIT_EVENT_PARALLEL_BITMAP_SCAN:
36553655
event_name = "ParallelBitmapScan";
36563656
break;
36573657
case WAIT_EVENT_PARALLEL_CREATE_INDEX_SCAN:
36583658
event_name = "ParallelCreateIndexScan";
36593659
break;
3660+
case WAIT_EVENT_PARALLEL_FINISH:
3661+
event_name = "ParallelFinish";
3662+
break;
36603663
case WAIT_EVENT_PROCARRAY_GROUP_UPDATE:
36613664
event_name = "ProcArrayGroupUpdate";
36623665
break;
3663-
case WAIT_EVENT_CLOG_GROUP_UPDATE:
3664-
event_name = "ClogGroupUpdate";
3665-
break;
36663666
case WAIT_EVENT_REPLICATION_ORIGIN_DROP:
36673667
event_name = "ReplicationOriginDrop";
36683668
break;

‎src/include/pgstat.h‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -759,8 +759,8 @@ typedef enum
759759
WAIT_EVENT_BGWRITER_HIBERNATE,
760760
WAIT_EVENT_BGWRITER_MAIN,
761761
WAIT_EVENT_CHECKPOINTER_MAIN,
762-
WAIT_EVENT_LOGICAL_LAUNCHER_MAIN,
763762
WAIT_EVENT_LOGICAL_APPLY_MAIN,
763+
WAIT_EVENT_LOGICAL_LAUNCHER_MAIN,
764764
WAIT_EVENT_PGSTAT_MAIN,
765765
WAIT_EVENT_RECOVERY_WAL_ALL,
766766
WAIT_EVENT_RECOVERY_WAL_STREAM,
@@ -802,6 +802,7 @@ typedef enum
802802
WAIT_EVENT_BGWORKER_SHUTDOWN = PG_WAIT_IPC,
803803
WAIT_EVENT_BGWORKER_STARTUP,
804804
WAIT_EVENT_BTREE_PAGE,
805+
WAIT_EVENT_CLOG_GROUP_UPDATE,
805806
WAIT_EVENT_EXECUTE_GATHER,
806807
WAIT_EVENT_HASH_BATCH_ALLOCATING,
807808
WAIT_EVENT_HASH_BATCH_ELECTING,
@@ -810,25 +811,24 @@ typedef enum
810811
WAIT_EVENT_HASH_BUILD_ELECTING,
811812
WAIT_EVENT_HASH_BUILD_HASHING_INNER,
812813
WAIT_EVENT_HASH_BUILD_HASHING_OUTER,
814+
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING,
815+
WAIT_EVENT_HASH_GROW_BATCHES_DECIDING,
813816
WAIT_EVENT_HASH_GROW_BATCHES_ELECTING,
814817
WAIT_EVENT_HASH_GROW_BATCHES_FINISHING,
815818
WAIT_EVENT_HASH_GROW_BATCHES_REPARTITIONING,
816-
WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING,
817-
WAIT_EVENT_HASH_GROW_BATCHES_DECIDING,
819+
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING,
818820
WAIT_EVENT_HASH_GROW_BUCKETS_ELECTING,
819821
WAIT_EVENT_HASH_GROW_BUCKETS_REINSERTING,
820-
WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING,
821822
WAIT_EVENT_LOGICAL_SYNC_DATA,
822823
WAIT_EVENT_LOGICAL_SYNC_STATE_CHANGE,
823824
WAIT_EVENT_MQ_INTERNAL,
824825
WAIT_EVENT_MQ_PUT_MESSAGE,
825826
WAIT_EVENT_MQ_RECEIVE,
826827
WAIT_EVENT_MQ_SEND,
827-
WAIT_EVENT_PARALLEL_FINISH,
828828
WAIT_EVENT_PARALLEL_BITMAP_SCAN,
829829
WAIT_EVENT_PARALLEL_CREATE_INDEX_SCAN,
830+
WAIT_EVENT_PARALLEL_FINISH,
830831
WAIT_EVENT_PROCARRAY_GROUP_UPDATE,
831-
WAIT_EVENT_CLOG_GROUP_UPDATE,
832832
WAIT_EVENT_REPLICATION_ORIGIN_DROP,
833833
WAIT_EVENT_REPLICATION_SLOT_DROP,
834834
WAIT_EVENT_SAFE_SNAPSHOT,

0 commit comments

Comments
 (0)