Remove vestigial CHECK_FOR_INTERRUPTS call.

tglsfdc · tglsfdc · commit 6b1a837f69d0 · 2016-01-07T11:26:54.000-05:00
Commit e710b65 inserted code in md5_crypt_verify to disable and later re-enable interrupts, with a CHECK_FOR_INTERRUPTS call as part of the second step, to process any interrupts that had been held off. Commit 6647248 removed the interrupt disable/re-enable code, but left behind the CHECK_FOR_INTERRUPTS, even though this is now an entirely random, pointless place for one. md5_crypt_verify doesn't run long enough to need such a check, and if it did, this would still be the wrong place to put one.
diff --git a/src/backend/libpq/crypt.c b/src/backend/libpq/crypt.c
@@ -81,8 +81,6 @@ md5_crypt_verify(const Port *port, const char *role, char *client_pass,
 		return STATUS_ERROR;	/* empty password */
 	}
 
-	CHECK_FOR_INTERRUPTS();
-
 	/*
 	 * Compare with the encrypted or plain password depending on the
 	 * authentication method being used for this connection.  (We do not

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,6 @@ md5_crypt_verify(const Port port, const char role, char *client_pass,`
`81`	`81`	`return STATUS_ERROR; /* empty password */`
`82`	`82`	`}`
`83`	`83`
`84`		`- CHECK_FOR_INTERRUPTS();`
`85`		`-`
`86`	`84`	`/*`
`87`	`85`	`* Compare with the encrypted or plain password depending on the`
`88`	`86`	`* authentication method being used for this connection. (We do not`