Fix off-by-one in pg_xlogdump -r option.

hlinnaka · hlinnaka · commit 79e15c7d86d3 · 2013-06-04T18:51:43.000+03:00
Because of the bug, -r would not accept the rmgr with the highest ID.
diff --git a/contrib/pg_xlogdump/pg_xlogdump.c b/contrib/pg_xlogdump/pg_xlogdump.c
@@ -75,7 +75,7 @@ print_rmgr_list(void)
 {
 	int			i;
 
-	for (i = 0; i < RM_MAX_ID + 1; i++)
+	for (i = 0; i <= RM_MAX_ID; i++)
 	{
 		printf("%s\n", RmgrDescTable[i].rm_name);
 	}
@@ -492,7 +492,7 @@ main(int argc, char **argv)
 						exit(EXIT_SUCCESS);
 					}
 
-					for (i = 0; i < RM_MAX_ID; i++)
+					for (i = 0; i <= RM_MAX_ID; i++)
 					{
 						if (pg_strcasecmp(optarg, RmgrDescTable[i].rm_name) == 0)
 						{

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ print_rmgr_list(void)`
`75`	`75`	`{`
`76`	`76`	`int i;`
`77`	`77`
`78`		`- for (i = 0; i < RM_MAX_ID + 1; i++)`
	`78`	`+ for (i = 0; i <= RM_MAX_ID; i++)`
`79`	`79`	`{`
`80`	`80`	`printf("%s\n", RmgrDescTable[i].rm_name);`
`81`	`81`	`}`
`@@ -492,7 +492,7 @@ main(int argc, char **argv)`
`492`	`492`	`exit(EXIT_SUCCESS);`
`493`	`493`	`}`
`494`	`494`
`495`		`- for (i = 0; i < RM_MAX_ID; i++)`
	`495`	`+ for (i = 0; i <= RM_MAX_ID; i++)`
`496`	`496`	`{`
`497`	`497`	`if (pg_strcasecmp(optarg, RmgrDescTable[i].rm_name) == 0)`
`498`	`498`	`{`