Remove unnecessary NULL test.

robertmhaas · robertmhaas · commit 8a8c581a8c99 · 2015-06-26T14:46:48.000-04:00
Spotted by Coverity and reported by Michael Paquier.  Per discussion,
we don't necessarily care about making Coverity happy in all such
instances, but we can go ahead and change them where it otherwise
seems to improve the code.
diff --git a/src/bin/pg_upgrade/controldata.c b/src/bin/pg_upgrade/controldata.c
@@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)
 		}
 	}
 
-	if (output)
-		pclose(output);
+	pclose(output);
 
 	/*
 	 * Restore environment variables

Original file line number	Diff line number	Diff line change
`@@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)`
`402`	`402`	`}`
`403`	`403`	`}`
`404`	`404`
`405`		`- if (output)`
`406`		`- pclose(output);`
	`405`	`+ pclose(output);`
`407`	`406`
`408`	`407`	`/*`
`409`	`408`	`* Restore environment variables`