Avoid calling pq_flush just after sending AUTH_REQ_OK; this saves one

tglsfdc · tglsfdc · commit 9103372f52ab · 2002-02-19T19:49:09.000Z
send() and probable process context swap during backend startup.
diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.72 2001/11/05 17:46:25 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.73 2002/02/19 19:49:09 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -619,9 +619,16 @@ sendAuthRequest(Port *port, AuthRequest areq)
 		pq_sendbytes(&buf, port->cryptSalt, 2);
 
 	pq_endmessage(&buf);
-	pq_flush();
+
+	/*
+	 * Flush message so client will see it, except for AUTH_REQ_OK,
+	 * which need not be sent until we are ready for queries.
+	 */
+	if (areq != AUTH_REQ_OK)
+		pq_flush();
 }
 
+
 #ifdef USE_PAM
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.72 2001/11/05 17:46:25 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.73 2002/02/19 19:49:09 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -619,9 +619,16 @@ sendAuthRequest(Port *port, AuthRequest areq)`
`619`	`619`	`pq_sendbytes(&buf, port->cryptSalt, 2);`
`620`	`620`
`621`	`621`	`pq_endmessage(&buf);`
`622`		`- pq_flush();`
	`622`	`+`
	`623`	`+ /*`
	`624`	`+ * Flush message so client will see it, except for AUTH_REQ_OK,`
	`625`	`+ * which need not be sent until we are ready for queries.`
	`626`	`+ */`
	`627`	`+ if (areq != AUTH_REQ_OK)`
	`628`	`+ pq_flush();`
`623`	`629`	`}`
`624`	`630`
	`631`	`+`
`625`	`632`	`#ifdef USE_PAM`
`626`	`633`
`627`	`634`	`/*`