Run pgindent on a batch of (mostly-planner-related) source files.

Getting annoyed at the amount of unrelated chatter I get from pgindent'ing
Rowley's unique-joins patch.  Re-indent all the files it touches.

Author: tglsfdc

contrib/postgres_fdw/postgres_fdw.c

@@ -317,9 +317,9 @@ static void postgresEndForeignModify(EState *estate,
 						 ResultRelInfo *resultRelInfo);
 static int	postgresIsForeignRelUpdatable(Relation rel);
 static bool postgresPlanDirectModify(PlannerInfo *root,
-									 ModifyTable *plan,
-									 Index resultRelation,
-									 int subplan_index);
+						 ModifyTable *plan,
+						 Index resultRelation,
+						 int subplan_index);
 static void postgresBeginDirectModify(ForeignScanState *node, int eflags);
 static TupleTableSlot *postgresIterateDirectModify(ForeignScanState *node);
 static void postgresEndDirectModify(ForeignScanState *node);
@@ -331,7 +331,7 @@ static void postgresExplainForeignModify(ModifyTableState *mtstate,
 							 int subplan_index,
 							 ExplainState *es);
 static void postgresExplainDirectModify(ForeignScanState *node,
-										ExplainState *es);
+							ExplainState *es);
 static bool postgresAnalyzeForeignTable(Relation relation,
 							AcquireSampleRowsFunc *func,
 							BlockNumber *totalpages);
@@ -2101,8 +2101,8 @@ postgresPlanDirectModify(PlannerInfo *root,
 		int			col;
 
 		/*
-		 * We transmit only columns that were explicitly targets of the UPDATE,
-		 * so as to avoid unnecessary data transmission.
+		 * We transmit only columns that were explicitly targets of the
+		 * UPDATE, so as to avoid unnecessary data transmission.
 		 */
 		col = -1;
 		while ((col = bms_next_member(rte->updatedCols, col)) >= 0)
@@ -2242,17 +2242,17 @@ postgresBeginDirectModify(ForeignScanState *node, int eflags)
 	dmstate->conn = GetConnection(user, false);
 
 	/* Initialize state variable */
-	dmstate->num_tuples = -1;		/* -1 means not set yet */
+	dmstate->num_tuples = -1;	/* -1 means not set yet */
 
 	/* Get private info created by planner functions. */
 	dmstate->query = strVal(list_nth(fsplan->fdw_private,
 									 FdwDirectModifyPrivateUpdateSql));
 	dmstate->has_returning = intVal(list_nth(fsplan->fdw_private,
-										 FdwDirectModifyPrivateHasReturning));
+										FdwDirectModifyPrivateHasReturning));
 	dmstate->retrieved_attrs = (List *) list_nth(fsplan->fdw_private,
-										FdwDirectModifyPrivateRetrievedAttrs);
+									   FdwDirectModifyPrivateRetrievedAttrs);
 	dmstate->set_processed = intVal(list_nth(fsplan->fdw_private,
-										 FdwDirectModifyPrivateSetProcessed));
+										FdwDirectModifyPrivateSetProcessed));
 
 	/* Create context for per-tuple temp workspace. */
 	dmstate->temp_cxt = AllocSetContextCreate(estate->es_query_cxt,
@@ -3911,10 +3911,10 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype,
 	List	   *otherclauses;
 
 	/*
-	 * Core code may call GetForeignJoinPaths hook even when the join
-	 * relation doesn't have a valid user mapping associated with it. See
-	 * build_join_rel() for details. We can't push down such join, since
-	 * there doesn't exist a user mapping which can be used to connect to the
+	 * Core code may call GetForeignJoinPaths hook even when the join relation
+	 * doesn't have a valid user mapping associated with it. See
+	 * build_join_rel() for details. We can't push down such join, since there
+	 * doesn't exist a user mapping which can be used to connect to the
 	 * foreign server.
 	 */
 	if (!OidIsValid(joinrel->umid))

src/backend/commands/explain.c

@@ -574,7 +574,7 @@ void
 ExplainPrintPlan(ExplainState *es, QueryDesc *queryDesc)
 {
 	Bitmapset  *rels_used = NULL;
-	PlanState *ps;
+	PlanState  *ps;
 
 	Assert(queryDesc->plannedstmt != NULL);
 	es->pstmt = queryDesc->plannedstmt;
@@ -1333,7 +1333,7 @@ ExplainNode(PlanState *planstate, List *ancestors,
 			break;
 		case T_Gather:
 			{
-				Gather *gather = (Gather *) plan;
+				Gather	   *gather = (Gather *) plan;
 
 				show_scan_qual(plan->qual, "Filter", planstate, ancestors, es);
 				if (plan->qual)
@@ -1343,7 +1343,7 @@ ExplainNode(PlanState *planstate, List *ancestors,
 									   gather->num_workers, es);
 				if (gather->single_copy)
 					ExplainPropertyText("Single Copy",
-										gather->single_copy ? "true" : "false",
+									  gather->single_copy ? "true" : "false",
 										es);
 			}
 			break;
@@ -1514,8 +1514,8 @@ ExplainNode(PlanState *planstate, List *ancestors,
 				appendStringInfo(es->str, "Worker %d: ", n);
 				if (es->timing)
 					appendStringInfo(es->str,
-							"actual time=%.3f..%.3f rows=%.0f loops=%.0f\n",
-								 startup_sec, total_sec, rows, nloops);
+							 "actual time=%.3f..%.3f rows=%.0f loops=%.0f\n",
+									 startup_sec, total_sec, rows, nloops);
 				else
 					appendStringInfo(es->str,
 									 "actual rows=%.0f loops=%.0f\n",
@@ -1671,6 +1671,7 @@ show_plan_tlist(PlanState *planstate, List *ancestors, ExplainState *es)
 		return;
 	if (IsA(plan, RecursiveUnion))
 		return;
+
 	/*
 	 * Likewise for ForeignScan that executes a direct INSERT/UPDATE/DELETE
 	 *
@@ -2329,7 +2330,7 @@ show_buffer_usage(ExplainState *es, const BufferUsage *usage)
 		bool		has_temp = (usage->temp_blks_read > 0 ||
 								usage->temp_blks_written > 0);
 		bool		has_timing = (!INSTR_TIME_IS_ZERO(usage->blk_read_time) ||
-								 !INSTR_TIME_IS_ZERO(usage->blk_write_time));
+								  !INSTR_TIME_IS_ZERO(usage->blk_write_time));
 
 		/* Show only positive counter values. */
 		if (has_shared || has_local || has_temp)
@@ -2393,10 +2394,10 @@ show_buffer_usage(ExplainState *es, const BufferUsage *usage)
 			appendStringInfoString(es->str, "I/O Timings:");
 			if (!INSTR_TIME_IS_ZERO(usage->blk_read_time))
 				appendStringInfo(es->str, " read=%0.3f",
-						  INSTR_TIME_GET_MILLISEC(usage->blk_read_time));
+							  INSTR_TIME_GET_MILLISEC(usage->blk_read_time));
 			if (!INSTR_TIME_IS_ZERO(usage->blk_write_time))
 				appendStringInfo(es->str, " write=%0.3f",
-						 INSTR_TIME_GET_MILLISEC(usage->blk_write_time));
+							 INSTR_TIME_GET_MILLISEC(usage->blk_write_time));
 			appendStringInfoChar(es->str, '\n');
 		}
 	}

src/backend/nodes/copyfuncs.c

@@ -4203,7 +4203,7 @@ _copyList(const List *from)
 static ExtensibleNode *
 _copyExtensibleNode(const ExtensibleNode *from)
 {
-	ExtensibleNode	   *newnode;
+	ExtensibleNode *newnode;
 	const ExtensibleNodeMethods *methods;
 
 	methods = GetExtensibleNodeMethods(from->extnodename, false);

src/backend/nodes/equalfuncs.c

@@ -879,7 +879,7 @@ _equalPlaceHolderInfo(const PlaceHolderInfo *a, const PlaceHolderInfo *b)
 static bool
 _equalExtensibleNode(const ExtensibleNode *a, const ExtensibleNode *b)
 {
-	const ExtensibleNodeMethods  *methods;
+	const ExtensibleNodeMethods *methods;
 
 	COMPARE_STRING_FIELD(extnodename);
 

src/backend/nodes/outfuncs.c

@@ -2332,7 +2332,7 @@ _outPlannerParamItem(StringInfo str, const PlannerParamItem *node)
 static void
 _outExtensibleNode(StringInfo str, const ExtensibleNode *node)
 {
-	const ExtensibleNodeMethods  *methods;
+	const ExtensibleNodeMethods *methods;
 
 	methods = GetExtensibleNodeMethods(node->extnodename, false);
 

src/backend/optimizer/path/costsize.c

@@ -47,7 +47,7 @@
  * plan nodes below the LIMIT node) are set without regard to any LIMIT, so
  * that this equation works properly.  (Note: while path->rows is never zero
  * for ordinary relations, it is zero for paths for provably-empty relations,
- * so beware of division-by-zero.)  The LIMIT is applied as a top-level
+ * so beware of division-by-zero.)	The LIMIT is applied as a top-level
  * plan node.
  *
  * For largely historical reasons, most of the routines in this module use
@@ -231,8 +231,8 @@ cost_seqscan(Path *path, PlannerInfo *root,
 	/* Adjust costing for parallelism, if used. */
 	if (path->parallel_degree > 0)
 	{
-		double	parallel_divisor = path->parallel_degree;
-		double	leader_contribution;
+		double		parallel_divisor = path->parallel_degree;
+		double		leader_contribution;
 
 		/*
 		 * Early experience with parallel query suggests that when there is

src/backend/optimizer/path/joinpath.c

@@ -348,12 +348,12 @@ try_nestloop_path(PlannerInfo *root,
  */
 static void
 try_partial_nestloop_path(PlannerInfo *root,
-				  RelOptInfo *joinrel,
-				  Path *outer_path,
-				  Path *inner_path,
-				  List *pathkeys,
-				  JoinType jointype,
-				  JoinPathExtraData *extra)
+						  RelOptInfo *joinrel,
+						  Path *outer_path,
+						  Path *inner_path,
+						  List *pathkeys,
+						  JoinType jointype,
+						  JoinPathExtraData *extra)
 {
 	JoinCostWorkspace workspace;
 
@@ -373,8 +373,8 @@ try_partial_nestloop_path(PlannerInfo *root,
 	}
 
 	/*
-	 * Before creating a path, get a quick lower bound on what it is likely
-	 * to cost.  Bail out right away if it looks terrible.
+	 * Before creating a path, get a quick lower bound on what it is likely to
+	 * cost.  Bail out right away if it looks terrible.
 	 */
 	initial_cost_nestloop(root, &workspace, jointype,
 						  outer_path, inner_path,
@@ -384,17 +384,17 @@ try_partial_nestloop_path(PlannerInfo *root,
 
 	/* Might be good enough to be worth trying, so let's try it. */
 	add_partial_path(joinrel, (Path *)
-			 create_nestloop_path(root,
-								  joinrel,
-								  jointype,
-								  &workspace,
-								  extra->sjinfo,
-								  &extra->semifactors,
-								  outer_path,
-								  inner_path,
-								  extra->restrictlist,
-								  pathkeys,
-								  NULL));
+					 create_nestloop_path(root,
+										  joinrel,
+										  jointype,
+										  &workspace,
+										  extra->sjinfo,
+										  &extra->semifactors,
+										  outer_path,
+										  inner_path,
+										  extra->restrictlist,
+										  pathkeys,
+										  NULL));
 }
 
 /*
@@ -571,8 +571,8 @@ try_partial_hashjoin_path(PlannerInfo *root,
 	}
 
 	/*
-	 * Before creating a path, get a quick lower bound on what it is likely
-	 * to cost.  Bail out right away if it looks terrible.
+	 * Before creating a path, get a quick lower bound on what it is likely to
+	 * cost.  Bail out right away if it looks terrible.
 	 */
 	initial_cost_hashjoin(root, &workspace, jointype, hashclauses,
 						  outer_path, inner_path,
@@ -582,17 +582,17 @@ try_partial_hashjoin_path(PlannerInfo *root,
 
 	/* Might be good enough to be worth trying, so let's try it. */
 	add_partial_path(joinrel, (Path *)
-			 create_hashjoin_path(root,
-								  joinrel,
-								  jointype,
-								  &workspace,
-								  extra->sjinfo,
-								  &extra->semifactors,
-								  outer_path,
-								  inner_path,
-								  extra->restrictlist,
-								  NULL,
-								  hashclauses));
+					 create_hashjoin_path(root,
+										  joinrel,
+										  jointype,
+										  &workspace,
+										  extra->sjinfo,
+										  &extra->semifactors,
+										  outer_path,
+										  inner_path,
+										  extra->restrictlist,
+										  NULL,
+										  hashclauses));
 }
 
 /*
@@ -1189,11 +1189,11 @@ match_unsorted_outer(PlannerInfo *root,
 	}
 
 	/*
-	 * If the joinrel is parallel-safe and the join type supports nested loops,
-	 * we may be able to consider a partial nestloop plan.  However, we can't
-	 * handle JOIN_UNIQUE_OUTER, because the outer path will be partial, and
-	 * therefore we won't be able to properly guarantee uniqueness.  Nor can
-	 * we handle extra_lateral_rels, since partial paths must not be
+	 * If the joinrel is parallel-safe and the join type supports nested
+	 * loops, we may be able to consider a partial nestloop plan.  However, we
+	 * can't handle JOIN_UNIQUE_OUTER, because the outer path will be partial,
+	 * and therefore we won't be able to properly guarantee uniqueness.  Nor
+	 * can we handle extra_lateral_rels, since partial paths must not be
 	 * parameterized.
 	 */
 	if (joinrel->consider_parallel && nestjoinOK &&
@@ -1235,10 +1235,10 @@ consider_parallel_nestloop(PlannerInfo *root,
 									   outerpath->pathkeys);
 
 		/*
-		 * Try the cheapest parameterized paths; only those which will
-		 * produce an unparameterized path when joined to this outerrel
-		 * will survive try_partial_nestloop_path.  The cheapest
-		 * unparameterized path is also in this list.
+		 * Try the cheapest parameterized paths; only those which will produce
+		 * an unparameterized path when joined to this outerrel will survive
+		 * try_partial_nestloop_path.  The cheapest unparameterized path is
+		 * also in this list.
 		 */
 		foreach(lc2, innerrel->cheapest_parameterized_paths)
 		{
@@ -1250,16 +1250,17 @@ consider_parallel_nestloop(PlannerInfo *root,
 
 			/*
 			 * Like match_unsorted_outer, we only consider a single nestloop
-			 * path when the jointype is JOIN_UNIQUE_INNER.  But we have to scan
-			 * cheapest_parameterized_paths to find the one we want to consider,
-			 * because cheapest_total_path might not be parallel-safe.
+			 * path when the jointype is JOIN_UNIQUE_INNER.  But we have to
+			 * scan cheapest_parameterized_paths to find the one we want to
+			 * consider, because cheapest_total_path might not be
+			 * parallel-safe.
 			 */
 			if (jointype == JOIN_UNIQUE_INNER)
 			{
 				if (!bms_is_empty(PATH_REQ_OUTER(innerpath)))
 					continue;
 				innerpath = (Path *) create_unique_path(root, innerrel,
-											   innerpath, extra->sjinfo);
+												   innerpath, extra->sjinfo);
 				Assert(innerpath);
 			}
 
@@ -1456,8 +1457,8 @@ hash_inner_and_outer(PlannerInfo *root,
 			outerrel->partial_pathlist != NIL &&
 			bms_is_empty(joinrel->lateral_relids))
 		{
-			Path   *cheapest_partial_outer;
-			Path   *cheapest_safe_inner = NULL;
+			Path	   *cheapest_partial_outer;
+			Path	   *cheapest_safe_inner = NULL;
 
 			cheapest_partial_outer =
 				(Path *) linitial(outerrel->partial_pathlist);

src/backend/optimizer/plan/planmain.c

@@ -70,10 +70,10 @@ query_planner(PlannerInfo *root, List *tlist,
 		final_rel = build_empty_join_rel(root);
 
 		/*
-		 * If query allows parallelism in general, check whether the quals
-		 * are parallel-restricted.  There's currently no real benefit to
-		 * setting this flag correctly because we can't yet reference subplans
-		 * from parallel workers.  But that might change someday, so set this
+		 * If query allows parallelism in general, check whether the quals are
+		 * parallel-restricted.  There's currently no real benefit to setting
+		 * this flag correctly because we can't yet reference subplans from
+		 * parallel workers.  But that might change someday, so set this
 		 * correctly anyway.
 		 */
 		if (root->glob->parallelModeOK)