Don't use function definitions looking like old-style ones.

This fixes a bunch of somewhat pedantic warnings with new
compilers. Since by far the majority of other functions definitions use
the (void) style it just seems to be consistent to do so as well in the
remaining few places.

Author: anarazel

contrib/pg_standby/pg_standby.c

@@ -171,7 +171,7 @@ CustomizableInitialize(void)
  *	  Is the requested file ready yet?
  */
 static bool
-CustomizableNextWALFileReady()
+CustomizableNextWALFileReady(void)
 {
 	if (stat(WALFilePath, &stat_buf) == 0)
 	{

src/backend/access/transam/twophase.c

@@ -295,7 +295,7 @@ AtAbort_Twophase(void)
  * PGXACT entry.
  */
 void
-PostPrepare_Twophase()
+PostPrepare_Twophase(void)
 {
 	LWLockAcquire(TwoPhaseStateLock, LW_EXCLUSIVE);
 	MyLockedGxact->locking_backend = InvalidBackendId;

src/backend/commands/trigger.c

@@ -3226,7 +3226,7 @@ static SetConstraintState SetConstraintStateAddItem(SetConstraintState state,
  * Gets the current query fdw tuplestore and initializes it if necessary
  */
 static Tuplestorestate *
-GetCurrentFDWTuplestore()
+GetCurrentFDWTuplestore(void)
 {
 	Tuplestorestate *ret;
 

src/backend/replication/logical/snapbuild.c

@@ -610,7 +610,7 @@ SnapBuildExportSnapshot(SnapBuild *builder)
  * owner back to its original value.
  */
 void
-SnapBuildClearExportedSnapshot()
+SnapBuildClearExportedSnapshot(void)
 {
 	/* nothing exported, thats the usual case */
 	if (!ExportInProgress)

src/backend/replication/repl_scanner.l

@@ -237,7 +237,7 @@ replication_scanner_init(const char *str)
 }
 
 void
-replication_scanner_finish()
+replication_scanner_finish(void)
 {
 	yy_delete_buffer(scanbufhandle);
 	scanbufhandle = NULL;

src/backend/replication/walsender.c

@@ -249,7 +249,7 @@ InitWalSender(void)
  * process, similar to what transaction abort does in a regular backend.
  */
 void
-WalSndErrorCleanup()
+WalSndErrorCleanup(void)
 {
 	LWLockReleaseAll();
 

src/backend/storage/ipc/dsm_impl.c

@@ -1027,7 +1027,7 @@ dsm_impl_pin_segment(dsm_handle handle, void *impl_private)
 }
 
 static int
-errcode_for_dynamic_shared_memory()
+errcode_for_dynamic_shared_memory(void)
 {
 	if (errno == EFBIG || errno == ENOMEM)
 		return errcode(ERRCODE_OUT_OF_MEMORY);

src/backend/utils/time/snapmgr.c

@@ -345,7 +345,7 @@ GetNonHistoricCatalogSnapshot(Oid relid)
  * cycles we spent tracking such fine details would be well-spent.
  */
 void
-InvalidateCatalogSnapshot()
+InvalidateCatalogSnapshot(void)
 {
 	CatalogSnapshotStale = true;
 }

src/bin/pg_resetxlog/pg_resetxlog.c

@@ -703,7 +703,7 @@ PrintControlValues(bool guessed)
  * Print the values to be changed.
  */
 static void
-PrintNewControlValues()
+PrintNewControlValues(void)
 {
 	char		fname[MAXFNAMELEN];
 

src/pl/plperl/plperl.c

@@ -2993,7 +2993,7 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
 
 
 static void
-check_spi_usage_allowed()
+check_spi_usage_allowed(void)
 {
 	/* see comment in plperl_fini() */
 	if (plperl_ending)