Assert that create_unique_path returns non-NULL.

robertmhaas · robertmhaas · commit eaf7b1f64324 · 2016-01-27T22:03:18.000-05:00
Per off-list discussion with Tom Lane and Michael Paquier, Coverity
gets unhappy if this is not done.
diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c
@@ -1259,6 +1259,7 @@ consider_parallel_nestloop(PlannerInfo *root,
 					continue;
 				innerpath = (Path *) create_unique_path(root, innerrel,
 											   innerpath, extra->sjinfo);
+				Assert(innerpath);
 			}
 
 			try_partial_nestloop_path(root, joinrel, outerpath, innerpath,

Original file line number	Diff line number	Diff line change
`@@ -1259,6 +1259,7 @@ consider_parallel_nestloop(PlannerInfo *root,`
`1259`	`1259`	`continue;`
`1260`	`1260`	`innerpath = (Path *) create_unique_path(root, innerrel,`
`1261`	`1261`	`innerpath, extra->sjinfo);`
	`1262`	`+ Assert(innerpath);`
`1262`	`1263`	`}`
`1263`	`1264`
`1264`	`1265`	`try_partial_nestloop_path(root, joinrel, outerpath, innerpath,`