pg_upgrade: adjust error output to use new database list format

bmomjian · bmomjian · commit 0c089d36e2bb · 2019-10-23T18:06:38.000-04:00
Commit a524f50 added old_11_check_for_sql_identifier_data_type_usage(), but it did not use the clearer database error list format added to the master branch in commit 1634d36. This commit fixes that. Backpatch-through: master
diff --git a/src/bin/pg_upgrade/version.c b/src/bin/pg_upgrade/version.c
@@ -540,7 +540,7 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster)
 						 strerror(errno));
 			if (!db_used)
 			{
-				fprintf(script, "Database: %s\n", active_db->db_name);
+				fprintf(script, "In database: %s\n", active_db->db_name);
 				db_used = true;
 			}
 			fprintf(script, "  %s.%s.%s\n",

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster)`
`540`	`540`	`strerror(errno));`
`541`	`541`	`if (!db_used)`
`542`	`542`	`{`
`543`		`- fprintf(script, "Database: %s\n", active_db->db_name);`
	`543`	`+ fprintf(script, "In database: %s\n", active_db->db_name);`
`544`	`544`	`db_used = true;`
`545`	`545`	`}`
`546`	`546`	`fprintf(script, " %s.%s.%s\n",`