Fix coverity complaint about commit 40d964e.

Amit Kapila · Amit Kapila · commit 2401d9371831 · 2020-04-01T09:28:13.000+05:30
The coverity complained that dividing integer expressions and then converting the integer quotient to type "double" would lose fractional part. Typecasting one of the arguments of expression with double should fix the report. Author: Mahendra Singh Thalor Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/20200329224818.6phnhv7o2q2rfovf@alap3.anarazel.de
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
@@ -2077,7 +2077,7 @@ compute_parallel_delay(void)
 	VacuumCostBalanceLocal += VacuumCostBalance;
 
 	if ((shared_balance >= VacuumCostLimit) &&
-		(VacuumCostBalanceLocal > 0.5 * (VacuumCostLimit / nworkers)))
+		(VacuumCostBalanceLocal > 0.5 * ((double) VacuumCostLimit / nworkers)))
 	{
 		/* Compute sleep time based on the local cost balance */
 		msec = VacuumCostDelay * VacuumCostBalanceLocal / VacuumCostLimit;

Original file line number	Diff line number	Diff line change
`@@ -2077,7 +2077,7 @@ compute_parallel_delay(void)`
`2077`	`2077`	`VacuumCostBalanceLocal += VacuumCostBalance;`
`2078`	`2078`
`2079`	`2079`	`if ((shared_balance >= VacuumCostLimit) &&`
`2080`		`- (VacuumCostBalanceLocal > 0.5 * (VacuumCostLimit / nworkers)))`
	`2080`	`+ (VacuumCostBalanceLocal > 0.5 * ((double) VacuumCostLimit / nworkers)))`
`2081`	`2081`	`{`
`2082`	`2082`	`/* Compute sleep time based on the local cost balance */`
`2083`	`2083`	`msec = VacuumCostDelay * VacuumCostBalanceLocal / VacuumCostLimit;`