Fix item addinfo corruption.

Maxim Orlov · Maxim Orlov · commit af616a0dd1fe · 2021-11-26T18:00:33.000+03:00
Copy item additional information from leaf data page. It is necessary when
additional information is used after the data page is unlocked.

In paricular when sorting of items should be done.
diff --git a/src/rumget.c b/src/rumget.c
@@ -464,11 +464,12 @@ collectMatchBitmap(RumBtreeData * btree, RumBtreeStack * stack,
 			char	*ptr = RumGetPosting(itup);
 			RumScanItem item;
 
+			MemSet(&item, 0, sizeof(item));
 			ItemPointerSetMin(&item.item.iptr);
 			for (i = 0; i < RumGetNPosting(itup); i++)
 			{
 				ptr = rumDataPageLeafRead(ptr, scanEntry->attnum, &item.item,
-										  false, rumstate);
+										  true, rumstate);
 				SCAN_ITEM_PUT_KEY(scanEntry, item, idatum, icategory);
 				rum_tuplesort_putrumitem(scanEntry->matchSortstate, &item);
 			}

Original file line number	Diff line number	Diff line change
`@@ -464,11 +464,12 @@ collectMatchBitmap(RumBtreeData * btree, RumBtreeStack * stack,`
`464`	`464`	`char *ptr = RumGetPosting(itup);`
`465`	`465`	`RumScanItem item;`
`466`	`466`
	`467`	`+ MemSet(&item, 0, sizeof(item));`
`467`	`468`	`ItemPointerSetMin(&item.item.iptr);`
`468`	`469`	`for (i = 0; i < RumGetNPosting(itup); i++)`
`469`	`470`	`{`
`470`	`471`	`ptr = rumDataPageLeafRead(ptr, scanEntry->attnum, &item.item,`
`471`		`- false, rumstate);`
	`472`	`+ true, rumstate);`
`472`	`473`	`SCAN_ITEM_PUT_KEY(scanEntry, item, idatum, icategory);`
`473`	`474`	`rum_tuplesort_putrumitem(scanEntry->matchSortstate, &item);`
`474`	`475`	`}`